[clang] [analyzer] Enforce not making overly complicated symbols (PR #144327)

[via cfe-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- clang/test/Analysis/ensure-capped-symbol-complexity.cpp clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymExpr.h clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h clang/lib/StaticAnalyzer/Checkers/Taint.cpp clang/lib/StaticAnalyzer/Checkers/TrustNonnullChecker.cpp clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp clang/lib/StaticAnalyzer/Core/SValBuilder.cpp clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp clang/lib/StaticAnalyzer/Core/SymbolManager.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h b/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h
index 3ed94c7fe..8fde5e7c1 100644
--- a/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h
+++ b/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h
@@ -165,7 +165,7 @@ class SymbolOverlyComplex final : public SymbolData {
   template <typename LHSTYPE, typename RHSTYPE,
             typename = assertTypesForOperands<LHSTYPE, RHSTYPE>>
   SymbolOverlyComplex(SymbolID Sym, LHSTYPE LHS, BinaryOperatorKind Op,
-                   RHSTYPE RHS, QualType Ty)
+                      RHSTYPE RHS, QualType Ty)
       : SymbolData(ClassKind, Sym), LHS(getPointer(LHS)), RHS(getPointer(RHS)),
         Ty(Ty), Op(static_cast<OpKindType>(Op)) {
     assert(this->LHS);
@@ -173,8 +173,8 @@ class SymbolOverlyComplex final : public SymbolData {
   }
 
   // Constructing from UnarySymExpr ctor arguments.
-  SymbolOverlyComplex(SymbolID Sym, const SymExpr *Operand, UnaryOperatorKind Op,
-                   QualType Ty)
+  SymbolOverlyComplex(SymbolID Sym, const SymExpr *Operand,
+                      UnaryOperatorKind Op, QualType Ty)
       : SymbolData(ClassKind, Sym), LHS(Operand), Ty(Ty),
         Op(static_cast<OpKindType>(Op)) {
     assert(LHS);
@@ -183,7 +183,7 @@ class SymbolOverlyComplex final : public SymbolData {
 
   // Constructing from SymbolCast ctor arguments.
   SymbolOverlyComplex(SymbolID Sym, const SymExpr *Operand, QualType,
-                   QualType ToTy)
+                      QualType ToTy)
       : SymbolData(ClassKind, Sym), LHS(Operand), Ty(ToTy), Op(~0) {}
 
 public:
@@ -787,7 +787,8 @@ const auto *SymbolManager::acquire(Args &&...args) {
     assert(T::computeComplexity(args...) == 1);
   } else {
     if (T::computeComplexity(args...) > MaxCompComplexity) {
-      return static_cast<const SymExpr *>(acquire<SymbolOverlyComplex>(args...));
+      return static_cast<const SymExpr *>(
+          acquire<SymbolOverlyComplex>(args...));
     }
   }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/144327