[clang] [analyzer] Enforce not making overly complicated symbols (PR #144327)

[Balázs Benics via cfe-commits]

balazs-benics-sonarsource wrote:

I was thinking about possible ways to unblock this change.

If the additional code complexity needs justification, by measuring the average impact (to ensure no regression happens in the common cases), and by repeating the measurement of the handful of edge-cases where it should bring noticeable (10%+) improvement. My estimate of these efforts would be a couple of days of work. I probably can't afford to spend this time.

It's hard to say, but there are two other options I'm contemplating:
 - ask for second opinions on Discuss (or here by CC-ing the other maintainers), or
 - abandon the patch (for now, possibly indefinitely).

But I don't really like either of these options.

I'm open for suggestions about how to proceed with this patch.

https://github.com/llvm/llvm-project/pull/144327