[clang] [Modules] Record whether VarDecl initializers contain side effects (PR #143739)

[Chuanqi Xu via cfe-commits]

================
@@ -1632,6 +1632,10 @@ RedeclarableResult ASTDeclReader::VisitVarDeclImpl(VarDecl *VD) {
     VD->NonParmVarDeclBits.PreviousDeclInSameBlockScope =
         VarDeclBits.getNextBit();
 
+    bool HasInitWithSideEffect = VarDeclBits.getNextBit();
+    if (HasInitWithSideEffect)
+      Reader.InitSideEffectVars.insert(VD);
----------------
ChuanqiXu9 wrote:

```suggestion
    if (VarDeclBits.getNextBit())
      Reader.InitSideEffectVars.insert(VD);
```

nit:

https://github.com/llvm/llvm-project/pull/143739