[clang-tools-extra] [clang-tidy] Add performance-bool-bitwise-operation check (PR #142324)

[Piotr Zegar via cfe-commits]

================
@@ -0,0 +1,239 @@
+//===--- BoolBitwiseOperationCheck.cpp - clang-tidy -----------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "BoolBitwiseOperationCheck.h"
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include "clang/Lex/Lexer.h"
+#include "llvm/ADT/ScopeExit.h"
+#include "llvm/ADT/Twine.h"
+#include <array>
+#include <optional>
+#include <utility>
+
+using namespace clang::ast_matchers;
+
+namespace clang::tidy::performance {
+
+static std::string tryPrintVariable(const BinaryOperator *BO) {
+  if (BO->isCompoundAssignmentOp()) {
+    const auto *DelcRefLHS =
+        dyn_cast<DeclRefExpr>(BO->getLHS()->IgnoreImpCasts());
+    if (DelcRefLHS)
+      return ("variable '" +
+              llvm::Twine(DelcRefLHS->getDecl()->getNameAsString()) + "'")
+          .str();
+  }
+  return "values";
+}
+
+static bool hasExplicitParentheses(const Expr *E, const SourceManager &SM,
+                                   const LangOptions &LangOpts) {
+  if (!E)
+    return false;
+
+  const SourceLocation Start = E->getBeginLoc();
+  const SourceLocation End = E->getEndLoc();
+
+  if (Start.isMacroID() || End.isMacroID() || Start.isInvalid() ||
+      End.isInvalid())
+    return false;
+
+  const std::optional<Token> PrevTok =
+      Lexer::findPreviousToken(Start, SM, LangOpts, /*IncludeComments=*/false);
+  const std::optional<Token> NextTok =
+      Lexer::findNextToken(End, SM, LangOpts, /*IncludeComments=*/false);
+
+  return (PrevTok && PrevTok->is(tok::l_paren)) &&
+         (NextTok && NextTok->is(tok::r_paren));
+}
+
+template <typename AstNode>
+static bool isInTemplateFunction(const AstNode *AN, ASTContext &Context) {
+  DynTypedNodeList Parents = Context.getParents(*AN);
----------------
PiotrZSL wrote:

Note: getParents is slow, just to know, actually this could be done as an Matcher

https://github.com/llvm/llvm-project/pull/142324