[clang] 4f7b5e6 - Fix a tablegen pattern that results in a warning; NFC

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 16 04:51:39 PDT 2025


Author: Aaron Ballman
Date: 2025-06-16T07:51:25-04:00
New Revision: 4f7b5e6d8327f8cea41ba31fdbbb0ee9c1f754c3

URL: https://github.com/llvm/llvm-project/commit/4f7b5e6d8327f8cea41ba31fdbbb0ee9c1f754c3
DIFF: https://github.com/llvm/llvm-project/commit/4f7b5e6d8327f8cea41ba31fdbbb0ee9c1f754c3.diff

LOG: Fix a tablegen pattern that results in a warning; NFC

We were generating `1 || 1` which caused some issues for -Werror builds

Added: 
    

Modified: 
    clang/utils/TableGen/ClangAttrEmitter.cpp

Removed: 
    


################################################################################
diff  --git a/clang/utils/TableGen/ClangAttrEmitter.cpp b/clang/utils/TableGen/ClangAttrEmitter.cpp
index 42627f02cf356..f892626a447e5 100644
--- a/clang/utils/TableGen/ClangAttrEmitter.cpp
+++ b/clang/utils/TableGen/ClangAttrEmitter.cpp
@@ -3739,7 +3739,8 @@ static void GenerateHasAttrSpellingStringSwitch(
                       : '(' + itostr(Version) + ')';
 
     if (Scope.empty() || Scope == Spelling.nameSpace()) {
-      if (TestStringMap.contains(Spelling.name()))
+      if (TestStringMap.contains(Spelling.name()) &&
+          TestStringMap[Spelling.name()] != TestStr)
         TestStringMap[Spelling.name()] += " || " + TestStr;
       else
         TestStringMap[Spelling.name()] = TestStr;


        


More information about the cfe-commits mailing list