[clang] [Sema] Use a range-based for loop (NFC) (PR #144252)
via cfe-commits
cfe-commits at lists.llvm.org
Sun Jun 15 00:49:29 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
Note that LLVM Coding Standards discourages for_each.
---
Full diff: https://github.com/llvm/llvm-project/pull/144252.diff
1 Files Affected:
- (modified) clang/lib/Sema/SemaOverload.cpp (+2-3)
``````````diff
diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp
index 49e5a311e239e..8c5f81f126c7a 100644
--- a/clang/lib/Sema/SemaOverload.cpp
+++ b/clang/lib/Sema/SemaOverload.cpp
@@ -9272,11 +9272,10 @@ class BuiltinOperatorOverloadBuilder {
/// the candidates into a unique set, then move from that set into the list
/// of arithmetic types.
llvm::SmallSetVector<CanQualType, 2> BitIntCandidates;
- llvm::for_each(CandidateTypes, [&BitIntCandidates](
- BuiltinCandidateTypeSet &Candidate) {
+ for (BuiltinCandidateTypeSet &Candidate : CandidateTypes) {
for (QualType BitTy : Candidate.bitint_types())
BitIntCandidates.insert(CanQualType::CreateUnsafe(BitTy));
- });
+ }
llvm::move(BitIntCandidates, std::back_inserter(ArithmeticTypes));
LastPromotedIntegralType = ArithmeticTypes.size();
LastPromotedArithmeticType = ArithmeticTypes.size();
``````````
</details>
https://github.com/llvm/llvm-project/pull/144252
More information about the cfe-commits
mailing list