[clang] [Clang][NFC][ByteCode] Initialize Function HasBody in constructor (PR #143443)

via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 9 14:39:07 PDT 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Shafik Yaghmour (shafik)

<details>
<summary>Changes</summary>

Static analysis flagged HasBody as not being initialized during construction. It looks like an oversight in: https://github.com/llvm/llvm-project/pull/139671

This would be a lot simpler with C++20 which allows in class initialization of bit-fields.

---
Full diff: https://github.com/llvm/llvm-project/pull/143443.diff


1 Files Affected:

- (modified) clang/lib/AST/ByteCode/Function.cpp (+1-1) 


``````````diff
diff --git a/clang/lib/AST/ByteCode/Function.cpp b/clang/lib/AST/ByteCode/Function.cpp
index 9eb6744ea47ad..0e639df3cafba 100644
--- a/clang/lib/AST/ByteCode/Function.cpp
+++ b/clang/lib/AST/ByteCode/Function.cpp
@@ -23,7 +23,7 @@ Function::Function(Program &P, FunctionDeclTy Source, unsigned ArgSize,
       ParamTypes(std::move(ParamTypes)), Params(std::move(Params)),
       ParamOffsets(std::move(ParamOffsets)), IsValid(false),
       IsFullyCompiled(false), HasThisPointer(HasThisPointer), HasRVO(HasRVO),
-      Defined(false) {
+      HasBody(false), Defined(false) {
   if (const auto *F = dyn_cast<const FunctionDecl *>(Source)) {
     Variadic = F->isVariadic();
     Immediate = F->isImmediateFunction();

``````````

</details>


https://github.com/llvm/llvm-project/pull/143443


More information about the cfe-commits mailing list