[clang] [clang] Diagnose [[nodiscard]] return types in Objective-C++ (PR #142541)

[via cfe-commits]

Sirraide wrote:

> factored out into a separate function

Not so much factored out as just made into a template since it is already a separate function.

https://github.com/llvm/llvm-project/pull/142541