[clang] [Sema] Implement fix as suggested by FIXME (PR #143142)

[via cfe-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp -- clang/lib/Sema/SemaOverload.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp
index 0e059239e..4bd8e8e88 100644
--- a/clang/lib/Sema/SemaOverload.cpp
+++ b/clang/lib/Sema/SemaOverload.cpp
@@ -757,7 +757,7 @@ clang::MakeDeductionFailureInfo(ASTContext &Context,
   case TemplateDeductionResult::DeducedMismatch:
   case TemplateDeductionResult::DeducedMismatchNested: {
     // Allocate from normal heap so that we can free this later.
-    auto *Saved = new  DFIDeducedMismatchArgs;
+    auto *Saved = new DFIDeducedMismatchArgs;
     Saved->FirstArg = Info.FirstArg;
     Saved->SecondArg = Info.SecondArg;
     Saved->TemplateArgs = Info.takeSugared();
@@ -768,7 +768,7 @@ clang::MakeDeductionFailureInfo(ASTContext &Context,
 
   case TemplateDeductionResult::NonDeducedMismatch: {
     // Allocate from normal heap so that we can free this later.
-    DFIArguments *Saved = new  DFIArguments;
+    DFIArguments *Saved = new DFIArguments;
     Saved->FirstArg = Info.FirstArg;
     Saved->SecondArg = Info.SecondArg;
     Result.Data = Saved;
@@ -780,7 +780,7 @@ clang::MakeDeductionFailureInfo(ASTContext &Context,
   case TemplateDeductionResult::Inconsistent:
   case TemplateDeductionResult::Underqualified: {
     // Allocate from normal heap so that we can free this later.
-    DFIParamWithArguments *Saved = new  DFIParamWithArguments;
+    DFIParamWithArguments *Saved = new DFIParamWithArguments;
     Saved->Param = Info.Param;
     Saved->FirstArg = Info.FirstArg;
     Saved->SecondArg = Info.SecondArg;
@@ -832,21 +832,21 @@ void DeductionFailureInfo::Destroy() {
   case TemplateDeductionResult::IncompletePack:
   case TemplateDeductionResult::Inconsistent:
   case TemplateDeductionResult::Underqualified:
-    delete static_cast<DFIParamWithArguments*>(Data);
+    delete static_cast<DFIParamWithArguments *>(Data);
     Data = nullptr;
     break;
   case TemplateDeductionResult::DeducedMismatch:
   case TemplateDeductionResult::DeducedMismatchNested:
-    delete static_cast<DFIDeducedMismatchArgs*>(Data);
+    delete static_cast<DFIDeducedMismatchArgs *>(Data);
     Data = nullptr;
     break;
   case TemplateDeductionResult::NonDeducedMismatch:
     // Destroy the data
-    delete static_cast<DFIArguments*>(Data);
+    delete static_cast<DFIArguments *>(Data);
     Data = nullptr;
     break;
 
-  case TemplateDeductionResult::SubstitutionFailure:{
+  case TemplateDeductionResult::SubstitutionFailure: {
     // FIXME: Destroy the template argument list?
     Data = nullptr;
     if (PartialDiagnosticAt *Diag = getSFINAEDiagnostic()) {
@@ -855,9 +855,9 @@ void DeductionFailureInfo::Destroy() {
     }
     break;
   }
-  case TemplateDeductionResult::ConstraintsNotSatisfied:{
+  case TemplateDeductionResult::ConstraintsNotSatisfied: {
     // Destroy the data
-    CNSInfo *Ptr = static_cast<CNSInfo*>(Data);
+    CNSInfo *Ptr = static_cast<CNSInfo *>(Data);
     delete Ptr;
     Data = nullptr;
     if (PartialDiagnosticAt *Diag = getSFINAEDiagnostic()) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/143142