[clang-tools-extra] 89cea0d - [clang-doc] Fix brittle check in test (#142665)

[via cfe-commits]

Author: Paul Kirth
Date: 2025-06-04T09:47:22-07:00
New Revision: 89cea0d26d13761e0c4afbc96aa2ccecbe8c0287

URL: https://github.com/llvm/llvm-project/commit/89cea0d26d13761e0c4afbc96aa2ccecbe8c0287
DIFF: https://github.com/llvm/llvm-project/commit/89cea0d26d13761e0c4afbc96aa2ccecbe8c0287.diff

LOG: [clang-doc] Fix brittle check in test (#142665)

Instead of having a platform specific error diagnostic, use a fixed one
with more direct context for the error.

Added: 
    

Modified: 
    clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
    clang-tools-extra/test/clang-doc/invalid-options.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clang-doc/tool/ClangDocMain.cpp b/clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
index 0d2415c619217..15de031aa6091 100644
--- a/clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
+++ b/clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
@@ -267,7 +267,8 @@ static llvm::Error handleMappingFailures(llvm::Error Err) {
 
 static llvm::Error createDirectories(llvm::StringRef OutDirectory) {
   if (std::error_code Err = llvm::sys::fs::create_directories(OutDirectory))
-    return llvm::createFileError(OutDirectory, Err);
+    return llvm::createFileError(OutDirectory, Err,
+                                 "failed to create directory.");
   return llvm::Error::success();
 }
 

diff  --git a/clang-tools-extra/test/clang-doc/invalid-options.cpp b/clang-tools-extra/test/clang-doc/invalid-options.cpp
index 59a0944718e31..15e098ad4c784 100644
--- a/clang-tools-extra/test/clang-doc/invalid-options.cpp
+++ b/clang-tools-extra/test/clang-doc/invalid-options.cpp
@@ -2,7 +2,7 @@
 // RUN: rm -rf %t && touch %t
 // RUN: not clang-doc %s -output=%t/subdir 2>&1 | FileCheck %s --check-prefix=OUTPUT-FAIL
 // OUTPUT-FAIL: clang-doc error:
-// OUTPUT-FAIL: {{(Not a directory|[Nn]o such file or directory)}}
+// OUTPUT-FAIL-SAME: failed to create directory.
 
 /// Invalid format option.
 // RUN: rm -rf %t && mkdir %t && touch %t/file