[clang-tools-extra] Follow style configuration in clangd when inserting missing includes (PR #140594)
via cfe-commits
cfe-commits at lists.llvm.org
Thu May 29 15:49:21 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- clang-tools-extra/clangd/IncludeCleaner.cpp clang-tools-extra/clangd/IncludeCleaner.h clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp b/clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp
index 7034685e6..ec733cbe9 100644
--- a/clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp
+++ b/clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp
@@ -282,7 +282,8 @@ $insert_vector[[]]
TU.AdditionalFiles["system/e.h"] = guard("#include <f.h>");
TU.AdditionalFiles["system/f.h"] = guard("void f();");
- TU.AdditionalFiles["system/quoted2_wrapper.h"] = guard("#include <system/quoted2.h>");
+ TU.AdditionalFiles["system/quoted2_wrapper.h"] =
+ guard("#include <system/quoted2.h>");
TU.AdditionalFiles["system/quoted2.h"] = guard("void quoted2();");
TU.ExtraArgs.push_back("-isystem" + testPath("system"));
@@ -340,12 +341,12 @@ $insert_vector[[]]
withFix({Fix(MainFile.range("insert_quoted"),
"#include \"quoted.h\"\n", "#include \"quoted.h\""),
FixMessage("add all missing includes")})),
- AllOf(
- Diag(MainFile.range("quoted2"),
- "No header providing \"quoted2\" is directly included"),
- withFix({Fix(MainFile.range("insert_quoted2"),
- "#include \"quoted2.h\"\n", "#include \"quoted2.h\""),
- FixMessage("add all missing includes")})),
+ AllOf(Diag(MainFile.range("quoted2"),
+ "No header providing \"quoted2\" is directly included"),
+ withFix(
+ {Fix(MainFile.range("insert_quoted2"),
+ "#include \"quoted2.h\"\n", "#include \"quoted2.h\""),
+ FixMessage("add all missing includes")})),
AllOf(Diag(MainFile.range("bar"),
"No header providing \"ns::Bar\" is directly included"),
withFix({Fix(MainFile.range("insert_d"),
``````````
</details>
https://github.com/llvm/llvm-project/pull/140594
More information about the cfe-commits
mailing list