[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

[Younan Zhang via cfe-commits]

================
@@ -13458,6 +13473,10 @@ class Sema final : public SemaBase {
   // FIXME: Should we have a similar limit for other forms of synthesis?
   unsigned NonInstantiationEntries;
 
+  /// The number of \p CodeSynthesisContexts that are not constraint
+  /// substitution.
+  unsigned NonConstraintSubstitutionEntries;
+
----------------
zyn0217 wrote:

Because we might be getting into ConstraintSubstitution context recursively


https://github.com/llvm/llvm-project/pull/122423