[clang] [clang][NFC] Move Diags.isIgnored check later in checkForRedundantLoop (PR #141470)
via cfe-commits
cfe-commits at lists.llvm.org
Mon May 26 03:24:24 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
<details>
<summary>Changes</summary>
... Iteration.
---
Full diff: https://github.com/llvm/llvm-project/pull/141470.diff
1 Files Affected:
- (modified) clang/lib/Sema/SemaStmt.cpp (+4-4)
``````````diff
diff --git a/clang/lib/Sema/SemaStmt.cpp b/clang/lib/Sema/SemaStmt.cpp
index ed070649dc1f9..6d6da6e7fdd8c 100644
--- a/clang/lib/Sema/SemaStmt.cpp
+++ b/clang/lib/Sema/SemaStmt.cpp
@@ -2207,16 +2207,16 @@ namespace {
// Return when there is nothing to check.
if (!Body || !Third) return;
- if (S.Diags.isIgnored(diag::warn_redundant_loop_iteration,
- Third->getBeginLoc()))
- return;
-
// Get the last statement from the loop body.
CompoundStmt *CS = dyn_cast<CompoundStmt>(Body);
if (!CS || CS->body_empty()) return;
Stmt *LastStmt = CS->body_back();
if (!LastStmt) return;
+ if (S.Diags.isIgnored(diag::warn_redundant_loop_iteration,
+ Third->getBeginLoc()))
+ return;
+
bool LoopIncrement, LastIncrement;
DeclRefExpr *LoopDRE, *LastDRE;
``````````
</details>
https://github.com/llvm/llvm-project/pull/141470
More information about the cfe-commits
mailing list