[libunwind] [libunwind][Haiku] Fix signal frame unwinding (PR #135367)

Brad Smith via cfe-commits cfe-commits at lists.llvm.org
Sun May 25 18:08:25 PDT 2025


brad0 wrote:

> You mean adding support for `i386`?

Yes.

> From what I understand about the linked issue, x86 is failing due to some signal frame unwinding function prototypes got leaked to general Haiku code, `_LIBUNWIND_TARGET_HAIKU`, but the implementation part got an additional `_LIBUNWIND_TARGET_X86_64` check.



> This PR guards both under `_LIBUNWIND_CHECK_HAIKU_SIGRETURN`, which has both the OS and architecture checks, effectively "fixing" `i386`.

I wasn't sure if that was the case or not. That's what it looks like, but I wasn't sure if it built on i386 and whether it has been build tested to ensure that is the case. At least building is still a step forward from not being able to build, which AFAIK, that is the case out of the box on i386 at the moment.

https://github.com/llvm/llvm-project/pull/135367


More information about the cfe-commits mailing list