[clang-tools-extra] [clang-tidy] Fix false positives with deducing this in `readability-convert-member-functions-to-static` check (PR #141391)
Baranov Victor via cfe-commits
cfe-commits at lists.llvm.org
Sun May 25 01:55:04 PDT 2025
================
@@ -79,10 +79,10 @@ void ConvertMemberFunctionsToStatic::registerMatchers(MatchFinder *Finder) {
cxxMethodDecl(
isDefinition(), isUserProvided(),
unless(anyOf(
- isExpansionInSystemHeader(), isVirtual(), isStatic(),
- hasTrivialBody(), isOverloadedOperator(), cxxConstructorDecl(),
- cxxDestructorDecl(), cxxConversionDecl(), isTemplate(),
- isDependentContext(),
+ isExplicitObjectMemberFunction(), isExpansionInSystemHeader(),
----------------
vbvictor wrote:
Please place `isExplicitObjectMemberFunction()` after `cxxConversionDecl()`. These predicates are checked from first to last in order, so for efficiency I'd put it after `cxxConversionDecl()`.
https://github.com/llvm/llvm-project/pull/141391
More information about the cfe-commits
mailing list