[clang-tools-extra] 4eb91b9 - [clang] Default-construct values with DenseMap::try_emplace (NFC) (#141373)

via cfe-commits cfe-commits at lists.llvm.org
Sat May 24 14:47:20 PDT 2025


Author: Kazu Hirata
Date: 2025-05-24T14:47:18-07:00
New Revision: 4eb91b9a6a31554ac6cb9bf211527bbcbb71ccb6

URL: https://github.com/llvm/llvm-project/commit/4eb91b9a6a31554ac6cb9bf211527bbcbb71ccb6
DIFF: https://github.com/llvm/llvm-project/commit/4eb91b9a6a31554ac6cb9bf211527bbcbb71ccb6.diff

LOG: [clang] Default-construct values with DenseMap::try_emplace (NFC) (#141373)

try_emplace can default-construct values, so we do not need to do so
on our own.

Added: 
    

Modified: 
    clang-tools-extra/clangd/index/SymbolCollector.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clangd/index/SymbolCollector.cpp b/clang-tools-extra/clangd/index/SymbolCollector.cpp
index 3f5633357073d..6bdb1080fb294 100644
--- a/clang-tools-extra/clangd/index/SymbolCollector.cpp
+++ b/clang-tools-extra/clangd/index/SymbolCollector.cpp
@@ -1201,7 +1201,7 @@ void SymbolCollector::addRef(SymbolID ID, const SymbolRef &SR) {
 }
 
 SymbolID SymbolCollector::getSymbolIDCached(const Decl *D) {
-  auto It = DeclToIDCache.try_emplace(D, SymbolID{});
+  auto It = DeclToIDCache.try_emplace(D);
   if (It.second)
     It.first->second = getSymbolID(D);
   return It.first->second;
@@ -1210,7 +1210,7 @@ SymbolID SymbolCollector::getSymbolIDCached(const Decl *D) {
 SymbolID SymbolCollector::getSymbolIDCached(const llvm::StringRef MacroName,
                                             const MacroInfo *MI,
                                             const SourceManager &SM) {
-  auto It = MacroToIDCache.try_emplace(MI, SymbolID{});
+  auto It = MacroToIDCache.try_emplace(MI);
   if (It.second)
     It.first->second = getSymbolID(MacroName, MI, SM);
   return It.first->second;


        


More information about the cfe-commits mailing list