[clang] [StaticAnalyzer] Use llvm::is_contained (NFC) (PR #141371)
via cfe-commits
cfe-commits at lists.llvm.org
Sat May 24 13:41:56 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/141371.diff
1 Files Affected:
- (modified) clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp (+2-4)
``````````diff
diff --git a/clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp b/clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp
index 77258958ae027..c9f5dc99aaf6b 100644
--- a/clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp
@@ -962,10 +962,8 @@ void RefLeakReport::findBindingToReport(CheckerContext &Ctx,
// `AllocFirstBinding` to be one of them. In situations like this,
// it would still be the easiest case to explain to our users.
if (!AllVarBindings.empty() &&
- llvm::count_if(AllVarBindings,
- [this](const std::pair<const MemRegion *, SVal> Binding) {
- return Binding.first == AllocFirstBinding;
- }) == 0) {
+ !llvm::is_contained(llvm::make_first_range(AllVarBindings),
+ AllocFirstBinding)) {
// Let's pick one of them at random (if there is something to pick from).
AllocBindingToReport = AllVarBindings[0].first;
``````````
</details>
https://github.com/llvm/llvm-project/pull/141371
More information about the cfe-commits
mailing list