[clang-tools-extra] 34e63be - [clang-doc] Prevent copying loop variables (NFC)

[Jie Fu via cfe-commits]

Author: Jie Fu
Date: 2025-05-23T09:00:19+08:00
New Revision: 34e63be925cc91d13f8c57c42664d9a678328f7c

URL: https://github.com/llvm/llvm-project/commit/34e63be925cc91d13f8c57c42664d9a678328f7c
DIFF: https://github.com/llvm/llvm-project/commit/34e63be925cc91d13f8c57c42664d9a678328f7c.diff

LOG: [clang-doc] Prevent copying loop variables (NFC)

/llvm-project/clang-tools-extra/clang-doc/HTMLMustacheGenerator.cpp:86:19:
error: loop variable '[Name, FileName]' creates a copy from type 'std::pair<llvm::StringRef, llvm::StringRef> const' [-Werror,-Wrange-loop-construct]
  for (const auto [Name, FileName] : Partials)
                  ^
/llvm-project/clang-tools-extra/clang-doc/HTMLMustacheGenerator.cpp:86:8:
note: use reference type 'std::pair<llvm::StringRef, llvm::StringRef> const &' to prevent copying
  for (const auto [Name, FileName] : Partials)
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                  &
1 error generated.

Added: 
    

Modified: 
    clang-tools-extra/clang-doc/HTMLMustacheGenerator.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clang-doc/HTMLMustacheGenerator.cpp b/clang-tools-extra/clang-doc/HTMLMustacheGenerator.cpp
index fd68b2e08ad98..6f51add830ed6 100644
--- a/clang-tools-extra/clang-doc/HTMLMustacheGenerator.cpp
+++ b/clang-tools-extra/clang-doc/HTMLMustacheGenerator.cpp
@@ -83,7 +83,7 @@ setupTemplate(std::unique_ptr<MustacheTemplateFile> &Template,
   if (Error Err = T.takeError())
     return Err;
   Template = std::move(T.get());
-  for (const auto [Name, FileName] : Partials)
+  for (const auto &[Name, FileName] : Partials)
     if (auto Err = Template->registerPartialFile(Name, FileName))
       return Err;
   return Error::success();