[clang] [clang-tools-extra] [clang] Fix LogDiagnosticPrinter.h and ClangTidyPlugin.cpp after 9e306ad4 (PR #141131)

[Jan Svoboda via cfe-commits]

jansvoboda11 wrote:

> @jansvoboda11 With this PR, I still see:
> 
> ```
> clang/lib/Frontend/LogDiagnosticPrinter.cpp:24:7: error: member initializer 'DiagOpts' does not name a non-static data member or base class
>    24 |       DiagOpts(DiagOpts) {}
>       |       ^~~~~~~~~~~~~~~~~~
> ```
> 
> Would you mind taking a look?

Fixed.



> I still see:
> 
> ```
> /usr/local/google/home/kazu/dev/llvm/llvm-project/llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:163:37: error: no member named 'Retain' in 'clang::DiagnosticOptions'
>   163 |   static void retain(T *obj) { obj->Retain(); }
>       |                                ~~~  ^
> ```
> 
> from `flang/lib/Frontend/TextDiagnosticPrinter.cpp`.

Working on a separate PR for Flang. Building to confirm I caught all issues.

https://github.com/llvm/llvm-project/pull/141131