[clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

Thu May 22 12:51:37 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `arc-builder` running on `arc-worker` while building `clang-tools-extra,clang,lldb` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/3/builds/16354

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
  306 |   bool visitInputFile(StringRef Filename, bool isSystem,
      |        ^~~~~~~~~~~~~~
cc1plus: note: unrecognized command-line option '-Wno-unnecessary-virtual-specifier' may have been intended to silence earlier diagnostics
584.018 [398/16/608] Building CXX object tools/clang/lib/Frontend/CMakeFiles/obj.clangFrontend.dir/PrecompiledPreamble.cpp.o
584.392 [397/16/609] Building CXX object tools/clang/lib/Frontend/Rewrite/CMakeFiles/obj.clangRewriteFrontend.dir/RewriteTest.cpp.o
584.585 [396/16/610] Building CXX object tools/clang/lib/Frontend/Rewrite/CMakeFiles/obj.clangRewriteFrontend.dir/HTMLPrint.cpp.o
588.780 [395/16/611] Building CXX object tools/clang/lib/Tooling/CMakeFiles/obj.clangTooling.dir/FixIt.cpp.o
589.428 [394/16/612] Building CXX object tools/clang/lib/Frontend/Rewrite/CMakeFiles/obj.clangRewriteFrontend.dir/RewriteModernObjC.cpp.o
589.543 [393/16/613] Building CXX object tools/clang/lib/Frontend/Rewrite/CMakeFiles/obj.clangRewriteFrontend.dir/RewriteObjC.cpp.o
594.163 [392/16/614] Building CXX object tools/clang/tools/clang-fuzzer/handle-cxx/CMakeFiles/obj.clangHandleCXX.dir/handle_cxx.cpp.o
FAILED: tools/clang/tools/clang-fuzzer/handle-cxx/CMakeFiles/obj.clangHandleCXX.dir/handle_cxx.cpp.o 
/usr/bin/c++ -DCLANG_EXPORTS -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/tools/clang-fuzzer/handle-cxx -I/buildbot/worker/arc-folder/llvm-project/clang/tools/clang-fuzzer/handle-cxx -I/buildbot/worker/arc-folder/llvm-project/clang/include -Itools/clang/include -Iinclude -I/buildbot/worker/arc-folder/llvm-project/llvm/include -I/buildbot/worker/arc-folder/llvm-project/clang/tools/clang-fuzzer/handle-cxx/. -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wno-unnecessary-virtual-specifier -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/clang/tools/clang-fuzzer/handle-cxx/CMakeFiles/obj.clangHandleCXX.dir/handle_cxx.cpp.o -MF tools/clang/tools/clang-fuzzer/handle-cxx/CMakeFiles/obj.clangHandleCXX.dir/handle_cxx.cpp.o.d -o tools/clang/tools/clang-fuzzer/handle-cxx/CMakeFiles/obj.clangHandleCXX.dir/handle_cxx.cpp.o -c /buildbot/worker/arc-folder/llvm-project/clang/tools/clang-fuzzer/handle-cxx/handle_cxx.cpp
/buildbot/worker/arc-folder/llvm-project/clang/tools/clang-fuzzer/handle-cxx/handle_cxx.cpp: In function 'void clang_fuzzer::HandleCXX(const string&, const char*, const std::vector<const char*>&)':
/buildbot/worker/arc-folder/llvm-project/clang/tools/clang-fuzzer/handle-cxx/handle_cxx.cpp:38:20: error: no matching function for call to 'clang::DiagnosticsEngine::DiagnosticsEngine(llvm::IntrusiveRefCntPtr<clang::DiagnosticIDs>, clang::DiagnosticOptions*, clang::IgnoringDiagConsumer*, bool)'
   38 |       &Diags, false);
      |                    ^
In file included from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/AST/NestedNameSpecifier.h:18,
                 from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/AST/Type.h:21,
                 from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/AST/CanonicalType.h:17,
                 from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/AST/ASTContext.h:18,
                 from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/Frontend/ASTUnit.h:17,
                 from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/Frontend/FrontendAction.h:23,
                 from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/CodeGen/CodeGenAction.h:12,
                 from /buildbot/worker/arc-folder/llvm-project/clang/tools/clang-fuzzer/handle-cxx/handle_cxx.cpp:15:
/buildbot/worker/arc-folder/llvm-project/clang/include/clang/Basic/Diagnostic.h:568:12: note: candidate: 'clang::DiagnosticsEngine::DiagnosticsEngine(llvm::IntrusiveRefCntPtr<clang::DiagnosticIDs>, clang::DiagnosticOptions&, clang::DiagnosticConsumer*, bool)'
  568 |   explicit DiagnosticsEngine(IntrusiveRefCntPtr<DiagnosticIDs> Diags,
      |            ^~~~~~~~~~~~~~~~~
/buildbot/worker/arc-folder/llvm-project/clang/include/clang/Basic/Diagnostic.h:569:49: note:   no known conversion for argument 2 from 'clang::DiagnosticOptions*' to 'clang::DiagnosticOptions&'
  569 |                              DiagnosticOptions &DiagOpts,
      |                              ~~~~~~~~~~~~~~~~~~~^~~~~~~~
In file included from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/Basic/DiagnosticIDs.h:19,
                 from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/Basic/Diagnostic.h:17,
                 from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/AST/NestedNameSpecifier.h:18,
                 from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/AST/Type.h:21,
                 from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/AST/CanonicalType.h:17,
                 from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/AST/ASTContext.h:18,
                 from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/Frontend/ASTUnit.h:17,
                 from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/Frontend/FrontendAction.h:23,
                 from /buildbot/worker/arc-folder/llvm-project/clang/include/clang/CodeGen/CodeGenAction.h:12,
                 from /buildbot/worker/arc-folder/llvm-project/clang/tools/clang-fuzzer/handle-cxx/handle_cxx.cpp:15:
/buildbot/worker/arc-folder/llvm-project/llvm/include/llvm/ADT/IntrusiveRefCntPtr.h: In instantiation of 'static void llvm::IntrusiveRefCntPtrInfo<T>::retain(T*) [with T = clang::DiagnosticOptions]':
/buildbot/worker/arc-folder/llvm-project/llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:228:40:   required from 'void llvm::IntrusiveRefCntPtr<T>::retain() [with T = clang::DiagnosticOptions]'
/buildbot/worker/arc-folder/llvm-project/llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:180:43:   required from 'llvm::IntrusiveRefCntPtr<T>::IntrusiveRefCntPtr(T*) [with T = clang::DiagnosticOptions]'
/buildbot/worker/arc-folder/llvm-project/clang/tools/clang-fuzzer/handle-cxx/handle_cxx.cpp:35:74:   required from here
/buildbot/worker/arc-folder/llvm-project/llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:163:37: error: 'class clang::DiagnosticOptions' has no member named 'Retain'
  163 |   static void retain(T *obj) { obj->Retain(); }
      |                                ~~~~~^~~~~~
/buildbot/worker/arc-folder/llvm-project/llvm/include/llvm/ADT/IntrusiveRefCntPtr.h: In instantiation of 'static void llvm::IntrusiveRefCntPtrInfo<T>::release(T*) [with T = clang::DiagnosticOptions]':
/buildbot/worker/arc-folder/llvm-project/llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:233:41:   required from 'void llvm::IntrusiveRefCntPtr<T>::release() [with T = clang::DiagnosticOptions]'

```

</details>

https://github.com/llvm/llvm-project/pull/139584