[clang] [llvm] [clang][DebugInfo] Add symbol for debugger with VTable information. (PR #130255)
Carlos Alberto Enciso via cfe-commits
cfe-commits at lists.llvm.org
Thu May 22 06:00:17 PDT 2025
CarlosAlbertoEnciso wrote:
> Could you remove the LLVM tests? They don't add coverage since tnhis isn't an LLVM feature - as far as LLVM is concerned, this is another static member variable like any other.
Removed all the LLVM tests.
>
> Why do some of the test cases use distinct input files/headers? I'd have thought these could all be written as standalone files with classes all written in a single file? (easier to read the test case in isolation, no implication that the header-ness matters (like this shouldn't be behaving differently because some content exists in a header V not, right?))
Moved all the code into a single file. The performed checks are the same.
Uploaded updated patch.
https://github.com/llvm/llvm-project/pull/130255
More information about the cfe-commits
mailing list