[clang] Revert "[Clang] Fix missed initializer instantiation bug for variable templates" (PR #140930)

[LLVM Continuous Integration via cfe-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-bootstrap-asan` running on `sanitizer-buildbot2` while building `clang` at step 2 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/52/builds/8514

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 2 (annotate) failure: 'python ../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_selector.py' (failure)
...
llvm-lit: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using lld-link: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/lld-link
llvm-lit: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using ld64.lld: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using wasm-ld: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using ld.lld: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/ld.lld
llvm-lit: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using lld-link: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/lld-link
llvm-lit: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using ld64.lld: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using wasm-ld: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/llvm/utils/lit/lit/main.py:72: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 900 seconds was requested on the command line. Forcing timeout to be 900 seconds.
-- Testing: 86635 tests, 88 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.
FAIL: lld :: COFF/lto-cache-errors.ll (83847 of 86635)
******************** TEST 'lld :: COFF/lto-cache-errors.ll' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
/home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/opt -module-hash -module-summary /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/lld/test/COFF/lto-cache-errors.ll -o /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.o # RUN: at line 5
+ /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/opt -module-hash -module-summary /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/lld/test/COFF/lto-cache-errors.ll -o /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.o
/home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/opt -module-hash -module-summary /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/lld/test/COFF/Inputs/lto-cache.ll -o /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp2.o # RUN: at line 6
+ /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/opt -module-hash -module-summary /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/lld/test/COFF/Inputs/lto-cache.ll -o /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp2.o
rm -Rf /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.cache && mkdir /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.cache # RUN: at line 7
+ rm -Rf /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.cache
+ mkdir /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.cache
chmod 444 /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.cache # RUN: at line 8
+ chmod 444 /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.cache
not /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/lld-link /lldltocache:/home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.cache/nonexistant/ /out:/home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp3 /entry:main /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp2.o /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.o 2>&1 | /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/FileCheck /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/lld/test/COFF/lto-cache-errors.ll # RUN: at line 11
+ not /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/lld-link /lldltocache:/home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.cache/nonexistant/ /out:/home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp3 /entry:main /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp2.o /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.o
+ /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/FileCheck /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/lld/test/COFF/lto-cache-errors.ll

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Slowest Tests:
--------------------------------------------------------------------------
29.28s: LLVM :: CodeGen/AMDGPU/amdgcn.bitcast.1024bit.ll
23.48s: LLVM :: tools/llvm-reduce/parallel-workitem-kill.ll
22.50s: Clang :: CodeGen/AArch64/sve-intrinsics/acle_sve_reinterpret.c
21.15s: Clang :: CodeGen/AArch64/sve-intrinsics/acle_sve_reinterpret-bfloat.c
17.94s: Clang :: Driver/fsanitize.c
15.14s: LLVM :: CodeGen/AMDGPU/memintrinsic-unroll.ll
14.51s: Clang :: Analysis/a_flaky_crash.cpp
14.28s: Clang :: Analysis/runtime-regression.c
14.09s: Clang :: Preprocessor/riscv-target-features.c
13.53s: LLVM :: CodeGen/AMDGPU/amdgcn.bitcast.512bit.ll
13.26s: LLVM :: CodeGen/AMDGPU/sched-group-barrier-pipeline-solver.mir
11.05s: Clang :: Analysis/PR24184.cpp
10.89s: LLVM :: CodeGen/AMDGPU/atomic_optimizations_global_pointer.ll
10.71s: Clang :: Driver/arm-cortex-cpus-2.c
Step 14 (stage3/asan check) failure: stage3/asan check (failure)
...
llvm-lit: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using lld-link: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/lld-link
llvm-lit: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using ld64.lld: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using wasm-ld: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using ld.lld: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/ld.lld
llvm-lit: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using lld-link: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/lld-link
llvm-lit: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using ld64.lld: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using wasm-ld: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/llvm/utils/lit/lit/main.py:72: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 900 seconds was requested on the command line. Forcing timeout to be 900 seconds.
-- Testing: 86635 tests, 88 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.
FAIL: lld :: COFF/lto-cache-errors.ll (83847 of 86635)
******************** TEST 'lld :: COFF/lto-cache-errors.ll' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
/home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/opt -module-hash -module-summary /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/lld/test/COFF/lto-cache-errors.ll -o /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.o # RUN: at line 5
+ /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/opt -module-hash -module-summary /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/lld/test/COFF/lto-cache-errors.ll -o /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.o
/home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/opt -module-hash -module-summary /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/lld/test/COFF/Inputs/lto-cache.ll -o /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp2.o # RUN: at line 6
+ /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/opt -module-hash -module-summary /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/lld/test/COFF/Inputs/lto-cache.ll -o /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp2.o
rm -Rf /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.cache && mkdir /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.cache # RUN: at line 7
+ rm -Rf /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.cache
+ mkdir /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.cache
chmod 444 /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.cache # RUN: at line 8
+ chmod 444 /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.cache
not /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/lld-link /lldltocache:/home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.cache/nonexistant/ /out:/home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp3 /entry:main /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp2.o /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.o 2>&1 | /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/FileCheck /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/lld/test/COFF/lto-cache-errors.ll # RUN: at line 11
+ not /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/lld-link /lldltocache:/home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.cache/nonexistant/ /out:/home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp3 /entry:main /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp2.o /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/tools/lld/test/COFF/Output/lto-cache-errors.ll.tmp.o
+ /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm_build2_asan/bin/FileCheck /home/b/sanitizer-x86_64-linux-bootstrap-asan/build/llvm-project/lld/test/COFF/lto-cache-errors.ll

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Slowest Tests:
--------------------------------------------------------------------------
29.28s: LLVM :: CodeGen/AMDGPU/amdgcn.bitcast.1024bit.ll
23.48s: LLVM :: tools/llvm-reduce/parallel-workitem-kill.ll
22.50s: Clang :: CodeGen/AArch64/sve-intrinsics/acle_sve_reinterpret.c
21.15s: Clang :: CodeGen/AArch64/sve-intrinsics/acle_sve_reinterpret-bfloat.c
17.94s: Clang :: Driver/fsanitize.c
15.14s: LLVM :: CodeGen/AMDGPU/memintrinsic-unroll.ll
14.51s: Clang :: Analysis/a_flaky_crash.cpp
14.28s: Clang :: Analysis/runtime-regression.c
14.09s: Clang :: Preprocessor/riscv-target-features.c
13.53s: LLVM :: CodeGen/AMDGPU/amdgcn.bitcast.512bit.ll
13.26s: LLVM :: CodeGen/AMDGPU/sched-group-barrier-pipeline-solver.mir
11.05s: Clang :: Analysis/PR24184.cpp
10.89s: LLVM :: CodeGen/AMDGPU/atomic_optimizations_global_pointer.ll
10.71s: Clang :: Driver/arm-cortex-cpus-2.c

```

</details>

https://github.com/llvm/llvm-project/pull/140930