[clang] [llvm] Add macro to suppress -Wunnecessary-virtual-specifier (PR #139614)

Wed May 21 13:17:14 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-gcc-ubuntu-no-asserts` running on `doug-worker-6` while building `clang,llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/202/builds/1367

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
0.856 [7192/8/1] Building CXX object lib/Demangle/CMakeFiles/LLVMDemangle.dir/DLangDemangle.cpp.o
1.364 [7191/8/2] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/ARMBuildAttributes.cpp.o
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/ARMBuildAttributes.cpp.o 
/opt/ccache/bin/g++ -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/buildbot-root/gcc-no-asserts/build/lib/Support -I/home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/lib/Support -I/home/buildbot/buildbot-root/gcc-no-asserts/build/include -I/home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -MD -MT lib/Support/CMakeFiles/LLVMSupport.dir/ARMBuildAttributes.cpp.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/ARMBuildAttributes.cpp.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/ARMBuildAttributes.cpp.o -c /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/lib/Support/ARMBuildAttributes.cpp
In file included from /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include/llvm/Support/ARMBuildAttributes.h:21,
                 from /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/lib/Support/ARMBuildAttributes.cpp:9:
/home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include/llvm/Support/Compiler.h:719:40: error: missing binary operator before token "("
  719 | #if defined(__clang__) && __has_warning("-Wunnecessary-virtual-specifier")
      |                                        ^
1.563 [7191/7/3] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/APSInt.cpp.o
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/APSInt.cpp.o 
/opt/ccache/bin/g++ -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/buildbot-root/gcc-no-asserts/build/lib/Support -I/home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/lib/Support -I/home/buildbot/buildbot-root/gcc-no-asserts/build/include -I/home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -MD -MT lib/Support/CMakeFiles/LLVMSupport.dir/APSInt.cpp.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/APSInt.cpp.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/APSInt.cpp.o -c /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/lib/Support/APSInt.cpp
In file included from /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include/llvm/ADT/APInt.h:18,
                 from /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include/llvm/ADT/APSInt.h:18,
                 from /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/lib/Support/APSInt.cpp:14:
/home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include/llvm/Support/Compiler.h:719:40: error: missing binary operator before token "("
  719 | #if defined(__clang__) && __has_warning("-Wunnecessary-virtual-specifier")
      |                                        ^
1.635 [7191/6/4] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/AArch64AttributeParser.cpp.o
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/AArch64AttributeParser.cpp.o 
/opt/ccache/bin/g++ -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/buildbot-root/gcc-no-asserts/build/lib/Support -I/home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/lib/Support -I/home/buildbot/buildbot-root/gcc-no-asserts/build/include -I/home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -MD -MT lib/Support/CMakeFiles/LLVMSupport.dir/AArch64AttributeParser.cpp.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/AArch64AttributeParser.cpp.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/AArch64AttributeParser.cpp.o -c /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/lib/Support/AArch64AttributeParser.cpp
In file included from /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include/llvm/Support/AArch64AttributeParser.h:12,
                 from /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/lib/Support/AArch64AttributeParser.cpp:10:
/home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include/llvm/Support/Compiler.h:719:40: error: missing binary operator before token "("
  719 | #if defined(__clang__) && __has_warning("-Wunnecessary-virtual-specifier")
      |                                        ^
1.796 [7191/5/5] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/APInt.cpp.o
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/APInt.cpp.o 
/opt/ccache/bin/g++ -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/buildbot-root/gcc-no-asserts/build/lib/Support -I/home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/lib/Support -I/home/buildbot/buildbot-root/gcc-no-asserts/build/include -I/home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -MD -MT lib/Support/CMakeFiles/LLVMSupport.dir/APInt.cpp.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/APInt.cpp.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/APInt.cpp.o -c /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/lib/Support/APInt.cpp
In file included from /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include/llvm/ADT/APInt.h:18,
                 from /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/lib/Support/APInt.cpp:14:
/home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include/llvm/Support/Compiler.h:719:40: error: missing binary operator before token "("
  719 | #if defined(__clang__) && __has_warning("-Wunnecessary-virtual-specifier")
      |                                        ^
1.859 [7191/4/6] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/APFixedPoint.cpp.o
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/APFixedPoint.cpp.o 
/opt/ccache/bin/g++ -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/buildbot-root/gcc-no-asserts/build/lib/Support -I/home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/lib/Support -I/home/buildbot/buildbot-root/gcc-no-asserts/build/include -I/home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -MD -MT lib/Support/CMakeFiles/LLVMSupport.dir/APFixedPoint.cpp.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/APFixedPoint.cpp.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/APFixedPoint.cpp.o -c /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/lib/Support/APFixedPoint.cpp
In file included from /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include/llvm/ADT/APInt.h:18,
                 from /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include/llvm/ADT/APSInt.h:18,
                 from /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include/llvm/ADT/APFixedPoint.h:19,
                 from /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/lib/Support/APFixedPoint.cpp:14:
/home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include/llvm/Support/Compiler.h:719:40: error: missing binary operator before token "("
  719 | #if defined(__clang__) && __has_warning("-Wunnecessary-virtual-specifier")
      |                                        ^
1.933 [7191/3/7] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/AArch64BuildAttributes.cpp.o
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/AArch64BuildAttributes.cpp.o 
/opt/ccache/bin/g++ -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/buildbot-root/gcc-no-asserts/build/lib/Support -I/home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/lib/Support -I/home/buildbot/buildbot-root/gcc-no-asserts/build/include -I/home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -MD -MT lib/Support/CMakeFiles/LLVMSupport.dir/AArch64BuildAttributes.cpp.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/AArch64BuildAttributes.cpp.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/AArch64BuildAttributes.cpp.o -c /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/lib/Support/AArch64BuildAttributes.cpp
In file included from /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include/llvm/ADT/STLFunctionalExtras.h:19,
                 from /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include/llvm/ADT/StringRef.h:13,
                 from /home/buildbot/buildbot-root/gcc-no-asserts/llvm-project/llvm/include/llvm/Support/AArch64BuildAttributes.h:21,

```

</details>

https://github.com/llvm/llvm-project/pull/139614