[clang-tools-extra] 64dcf78 - [clang-tidy][NFC] Refactor `modernize-pass-by-value` check code and tests (#140753)
via cfe-commits
cfe-commits at lists.llvm.org
Wed May 21 01:34:48 PDT 2025
Author: Baranov Victor
Date: 2025-05-21T10:34:45+02:00
New Revision: 64dcf7893554b44b2a79d23ea0b21d6f3fc2e38f
URL: https://github.com/llvm/llvm-project/commit/64dcf7893554b44b2a79d23ea0b21d6f3fc2e38f
DIFF: https://github.com/llvm/llvm-project/commit/64dcf7893554b44b2a79d23ea0b21d6f3fc2e38f.diff
LOG: [clang-tidy][NFC] Refactor `modernize-pass-by-value` check code and tests (#140753)
- Deleted unused includes
- Deleted useless braces
- Modernized tests to use `CHECK-MESSAGES-NOT` and `CHECK-FIXES-NOT` for
better readability and maintainability
Added:
Modified:
clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp
clang-tools-extra/clang-tidy/modernize/PassByValueCheck.h
clang-tools-extra/test/clang-tidy/checkers/modernize/pass-by-value.cpp
Removed:
################################################################################
diff --git a/clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp b/clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp
index 7a9d04bfa8ba1..35f90fb8da15b 100644
--- a/clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp
+++ b/clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp
@@ -166,9 +166,8 @@ static bool hasRValueOverload(const CXXConstructorDecl *Ctor,
};
for (const auto *Candidate : Record->ctors()) {
- if (IsRValueOverload(Candidate)) {
+ if (IsRValueOverload(Candidate))
return true;
- }
}
return false;
}
diff --git a/clang-tools-extra/clang-tidy/modernize/PassByValueCheck.h b/clang-tools-extra/clang-tidy/modernize/PassByValueCheck.h
index c7677edc37dc4..b586b8d5fbf66 100644
--- a/clang-tools-extra/clang-tidy/modernize/PassByValueCheck.h
+++ b/clang-tools-extra/clang-tidy/modernize/PassByValueCheck.h
@@ -12,8 +12,6 @@
#include "../ClangTidyCheck.h"
#include "../utils/IncludeInserter.h"
-#include <memory>
-
namespace clang::tidy::modernize {
class PassByValueCheck : public ClangTidyCheck {
diff --git a/clang-tools-extra/test/clang-tidy/checkers/modernize/pass-by-value.cpp b/clang-tools-extra/test/clang-tidy/checkers/modernize/pass-by-value.cpp
index c0ebaebe4ccf6..be33988607b27 100644
--- a/clang-tools-extra/test/clang-tidy/checkers/modernize/pass-by-value.cpp
+++ b/clang-tools-extra/test/clang-tidy/checkers/modernize/pass-by-value.cpp
@@ -32,7 +32,6 @@ struct A {
Movable GlobalObj;
struct B {
B(const Movable &M) : M(GlobalObj) {}
- // CHECK-FIXES: B(const Movable &M) : M(GlobalObj) {}
Movable M;
};
@@ -40,11 +39,9 @@ struct B {
struct C {
// Tests extra-reference in body.
C(const Movable &M) : M(M) { this->i = M.a; }
- // CHECK-FIXES: C(const Movable &M) : M(M) { this->i = M.a; }
// Tests extra-reference in init-list.
C(const Movable &M, int) : M(M), i(M.a) {}
- // CHECK-FIXES: C(const Movable &M, int) : M(M), i(M.a) {}
Movable M;
int i;
};
@@ -70,7 +67,6 @@ struct E {
// Test with object that can't be moved.
struct F {
F(const NotMovable &NM) : NM(NM) {}
- // CHECK-FIXES: F(const NotMovable &NM) : NM(NM) {}
NotMovable NM;
};
@@ -112,7 +108,6 @@ struct I {
// Test that templates aren't modified.
template <typename T> struct J {
J(const T &M) : M(M) {}
- // CHECK-FIXES: J(const T &M) : M(M) {}
T M;
};
J<Movable> j1(Movable());
@@ -129,13 +124,11 @@ struct MovableTemplateT
template <class T>
struct J2 {
J2(const MovableTemplateT<T>& A);
- // CHECK-FIXES: J2(const MovableTemplateT<T>& A);
MovableTemplateT<T> M;
};
template <class T>
J2<T>::J2(const MovableTemplateT<T>& A) : M(A) {}
-// CHECK-FIXES: J2<T>::J2(const MovableTemplateT<T>& A) : M(A) {}
J2<int> j3(MovableTemplateT<int>{});
struct K_Movable {
@@ -182,7 +175,6 @@ struct O {
// Test with a const-value parameter.
struct P {
P(const Movable M) : M(M) {}
- // CHECK-FIXES: P(const Movable M) : M(M) {}
Movable M;
};
@@ -215,7 +207,6 @@ struct R {
// Test with rvalue parameter.
struct S {
S(Movable &&M) : M(M) {}
- // CHECK-FIXES: S(Movable &&M) : M(M) {}
Movable M;
};
@@ -225,13 +216,11 @@ template <typename T, int N> struct array { T A[N]; };
// cause problems with performance-move-const-arg, as it will revert it.
struct T {
T(array<int, 10> a) : a_(a) {}
- // CHECK-FIXES: T(array<int, 10> a) : a_(a) {}
array<int, 10> a_;
};
struct U {
U(const POD &M) : M(M) {}
- // CHECK-FIXES: U(const POD &M) : M(M) {}
POD M;
};
More information about the cfe-commits
mailing list