[clang] [lld] [llvm] Adding Matching and Inference Functionality to Propeller (PR #139008)

[James Henderson via cfe-commits]

jh7370 wrote:

> > Thanks for the patch. I think this PR should be split up a bit, so that it's easier to review distinct sections. In particular the areas related to yaml2obj/obj2yaml, llvm-readobj and llvm-objdump could probably be their own PR, where we can focus on reviewing how tools read the data.
> 
> Thanks for your advice. We will split the PR into smaller ones. However, modifying the bb_address_map section requires synchronously updating yaml2obj/obj2yaml, llvm-readobj, and llvm-objdump to ensure that the test cases pass. We may not be able to submit separate PRs for yaml2obj/obj2yaml, llvm-readobj, and llvm-objdump.

I meant 1+ PRs that cover those tools. Typically there should be no need for both llvm-objdump and llvm-readobj additions in the same PR, so you make 2. Similarly ob2yaml (not to be confused with yaml2obj support isn't needed to be able to test llvm-readobj/llvm-objdump can read the code, so typically that would be its own PR too. That ultimately means you could have three PRs just to cover these tools: 1) llvm-readobj + yaml2obj, 2) llvm-objdump, 3) obj2yaml.

https://github.com/llvm/llvm-project/pull/139008