[clang-tools-extra] [clang-tidy][NFC] Refactor `modernize-pass-by-value` check code and tests (PR #140753)

[Carlos Galvez via cfe-commits]

carlosgalvezp wrote:

Also, CHECK-MESSAGES-NOT is discouraged, since the testing framework already checked that no other output is produced by default.

https://github.com/llvm/llvm-project/pull/140753