[clang-tools-extra] [clang-tools-extra] Use llvm::find_if (NFC) (PR #140411)
Kazu Hirata via cfe-commits
cfe-commits at lists.llvm.org
Sat May 17 15:09:35 PDT 2025
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/140411
None
>From b1dde26817af09f18cfe5fd4a1779d3720b7f6b8 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Sat, 17 May 2025 14:36:45 -0700
Subject: [PATCH] [clang-tools-extra] Use llvm::find_if (NFC)
---
.../misc/NewDeleteOverloadsCheck.cpp | 31 +++++++++----------
clang-tools-extra/clangd/refactor/Rename.cpp | 5 ++-
2 files changed, 17 insertions(+), 19 deletions(-)
diff --git a/clang-tools-extra/clang-tidy/misc/NewDeleteOverloadsCheck.cpp b/clang-tools-extra/clang-tidy/misc/NewDeleteOverloadsCheck.cpp
index 32ea0c0cdf48c..40808aaf7c3da 100644
--- a/clang-tools-extra/clang-tidy/misc/NewDeleteOverloadsCheck.cpp
+++ b/clang-tools-extra/clang-tidy/misc/NewDeleteOverloadsCheck.cpp
@@ -168,22 +168,21 @@ void NewDeleteOverloadsCheck::onEndOfTranslationUnit() {
// complexity when searching for corresponding free store functions.
for (const auto *Overload : RP.second) {
const auto *Match =
- std::find_if(RP.second.begin(), RP.second.end(),
- [&Overload](const FunctionDecl *FD) {
- if (FD == Overload)
- return false;
- // If the declaration contexts don't match, we don't
- // need to check any further.
- if (FD->getDeclContext() != Overload->getDeclContext())
- return false;
-
- // Since the declaration contexts match, see whether
- // the current element is the corresponding operator.
- if (!areCorrespondingOverloads(Overload, FD))
- return false;
-
- return true;
- });
+ llvm::find_if(RP.second, [&Overload](const FunctionDecl *FD) {
+ if (FD == Overload)
+ return false;
+ // If the declaration contexts don't match, we don't
+ // need to check any further.
+ if (FD->getDeclContext() != Overload->getDeclContext())
+ return false;
+
+ // Since the declaration contexts match, see whether
+ // the current element is the corresponding operator.
+ if (!areCorrespondingOverloads(Overload, FD))
+ return false;
+
+ return true;
+ });
if (Match == RP.second.end()) {
// Check to see if there is a corresponding overload in a base class
diff --git a/clang-tools-extra/clangd/refactor/Rename.cpp b/clang-tools-extra/clangd/refactor/Rename.cpp
index e464f1ad45c52..d9b73b83e902a 100644
--- a/clang-tools-extra/clangd/refactor/Rename.cpp
+++ b/clang-tools-extra/clangd/refactor/Rename.cpp
@@ -185,9 +185,8 @@ void filterRenameTargets(llvm::DenseSet<const NamedDecl *> &Decls) {
// For renaming, we're only interested in foo's declaration, so drop the other
// one. There should never be more than one UsingDecl here, otherwise the
// rename would be ambiguos anyway.
- auto UD = std::find_if(Decls.begin(), Decls.end(), [](const NamedDecl *D) {
- return llvm::isa<UsingDecl>(D);
- });
+ auto UD = llvm::find_if(
+ Decls, [](const NamedDecl *D) { return llvm::isa<UsingDecl>(D); });
if (UD != Decls.end()) {
Decls.erase(UD);
}
More information about the cfe-commits
mailing list