[clang] [libcxx] libcxx: std::ostream::sentry should be exported (PR #140169)
via cfe-commits
cfe-commits at lists.llvm.org
Fri May 16 14:40:19 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions ,cpp,h -- clang/lib/Sema/SemaTemplateInstantiate.cpp clang/test/CodeGenCXX/mingw-template-dllexport.cpp libcxx/include/__ostream/basic_ostream.h libcxx/include/istream
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/libcxx/include/__ostream/basic_ostream.h b/libcxx/include/__ostream/basic_ostream.h
index 0e277c8ed..2b34b1957 100644
--- a/libcxx/include/__ostream/basic_ostream.h
+++ b/libcxx/include/__ostream/basic_ostream.h
@@ -665,16 +665,16 @@ basic_ostream<char, _Traits>& operator<<(basic_ostream<char, _Traits>&, const ch
# endif // _LIBCPP_STD_VER >= 20
-#if defined(__MINGW32__) || defined(__CYGWIN__)
+# if defined(__MINGW32__) || defined(__CYGWIN__)
extern template _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS basic_ostream<char>::sentry::sentry(basic_ostream<char>& __os);
extern template _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS basic_ostream<char>::sentry::~sentry();
-#endif
+# endif
extern template class _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS basic_ostream<char>;
# if _LIBCPP_HAS_WIDE_CHARACTERS
-# if defined(__MINGW32__) || defined(__CYGWIN__)
+# if defined(__MINGW32__) || defined(__CYGWIN__)
extern template _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS basic_ostream<wchar_t>::sentry::sentry(basic_ostream<wchar_t>& __os);
extern template _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS basic_ostream<wchar_t>::sentry::~sentry();
-# endif
+# endif
extern template class _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS basic_ostream<wchar_t>;
# endif
``````````
</details>
https://github.com/llvm/llvm-project/pull/140169
More information about the cfe-commits
mailing list