[clang] [llvm] [NFC] Address bit-field storage sizes to ensure ideal packing (PR #139825)

[Oliver Hunt via cfe-commits]

ojhunt wrote:

The format problems are existing style that I don't want to reformat in this PR:

```diff
diff --git a/clang/include/clang/Basic/DiagnosticCategories.h b/clang/include/clang/Basic/DiagnosticCategories.h
index 52bb7a268b41..f7b2af8d194a 100644
--- a/clang/include/clang/Basic/DiagnosticCategories.h
+++ b/clang/include/clang/Basic/DiagnosticCategories.h
@@ -11,23 +11,23 @@
 
 namespace clang {
   namespace diag {
-    enum DiagCategory {
+  enum DiagCategory {
 #define GET_CATEGORY_TABLE
 #define CATEGORY(X, ENUM) ENUM,
 #include "clang/Basic/DiagnosticGroups.inc"
 #undef CATEGORY
 #undef GET_CATEGORY_TABLE
-      DiagCat_NUM_CATEGORIES
-    };
+    DiagCat_NUM_CATEGORIES
+  };
 
-    enum class Group {
-#define DIAG_ENTRY(GroupName, FlagNameOffset, Members, SubGroups, Docs)    \
-      GroupName,
+  enum class Group {
+#define DIAG_ENTRY(GroupName, FlagNameOffset, Members, SubGroups, Docs)      \
+    GroupName,
 #include "clang/Basic/DiagnosticGroups.inc"
 #undef CATEGORY
 #undef DIAG_ENTRY
-      NUM_GROUPS
-    };
+    NUM_GROUPS
+  };
   }  // end namespace diag
 }  // end namespace clang
 
diff --git a/clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h b/clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
index 543ac8ab2ab1..34c6621a29c1 100644
--- a/clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
+++ b/clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
@@ -404,16 +404,14 @@ public:
   bool mayInlineCXXMemberFunction(CXXInlineableMemberKind K) const;
 
   ento::PathDiagnosticConsumerOptions getDiagOpts() const {
-    return {FullCompilerInvocation,
-            ShouldDisplayMacroExpansions,
+    return {FullCompilerInvocation, ShouldDisplayMacroExpansions,
             ShouldSerializeStats,
             // The stable report filename option is deprecated because
             // file names are now always stable. Now the old option acts as
             // an alias to the new verbose filename option because this
             // closely mimics the behavior under the old option.
             ShouldWriteStableReportFilename || ShouldWriteVerboseReportFilename,
-            static_cast<bool>(AnalyzerWerror),
-            ShouldApplyFixIts,
+            static_cast<bool>(AnalyzerWerror), ShouldApplyFixIts,
             ShouldDisplayCheckerNameForText};
   }
 };
diff --git a/llvm/include/llvm/Bitstream/BitCodes.h b/llvm/include/llvm/Bitstream/BitCodes.h
index 205024f754df..3df10636203d 100644
--- a/llvm/include/llvm/Bitstream/BitCodes.h
+++ b/llvm/include/llvm/Bitstream/BitCodes.h
@@ -42,11 +42,11 @@ public:
   };
 
 protected:
-  uint64_t Val;           // A literal value or data for an encoding.
+  uint64_t Val; // A literal value or data for an encoding.
   LLVM_PREFERRED_TYPE(bool)
   uint64_t IsLiteral : 1; // Indicate whether this is a literal value or not.
   LLVM_PREFERRED_TYPE(Encoding)
-  uint64_t Enc : 3;       // The encoding to use.
+  uint64_t Enc : 3; // The encoding to use.
 
 public:
   static bool isValidEncoding(uint64_t E) {
@@ -100,7 +100,6 @@ public:
     return "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789._"
         [V];
   }
-
 };
 
 /// BitCodeAbbrev - This class represents an abbreviation record.  An
diff --git a/llvm/include/llvm/Demangle/ItaniumDemangle.h b/llvm/include/llvm/Demangle/ItaniumDemangle.h
index 7c24995e7463..9e55bbfc7d80 100644
--- a/llvm/include/llvm/Demangle/ItaniumDemangle.h
+++ b/llvm/include/llvm/Demangle/ItaniumDemangle.h
@@ -172,7 +172,11 @@ public:
 
   /// Three-way bool to track a cached value. Unknown is possible if this node
   /// has an unexpanded parameter pack below it that may affect this cache.
-  enum class Cache : uint8_t { Yes, No, Unknown, };
+  enum class Cache : uint8_t {
+    Yes,
+    No,
+    Unknown,
+  };
 
   /// Operator precedence for expression nodes. Used to determine required
   /// parens in expression emission.
diff --git a/llvm/lib/Target/AArch64/AArch64CollectLOH.cpp b/llvm/lib/Target/AArch64/AArch64CollectLOH.cpp
index c3370cd6e946..0bb4493773e1 100644
--- a/llvm/lib/Target/AArch64/AArch64CollectLOH.cpp
+++ b/llvm/lib/Target/AArch64/AArch64CollectLOH.cpp
@@ -273,9 +273,9 @@ static int mapRegToGPRIndex(MCRegister Reg) {
 struct LOHInfo {
   MCLOHType Type : 8;           ///< "Best" type of LOH possible.
   LLVM_PREFERRED_TYPE(bool)
-  unsigned IsCandidate : 1;     ///< Possible LOH candidate.
+  unsigned IsCandidate : 1; ///< Possible LOH candidate.
   LLVM_PREFERRED_TYPE(bool)
-  unsigned OneUser : 1;         ///< Found exactly one user (yet).
+  unsigned OneUser : 1; ///< Found exactly one user (yet).
   LLVM_PREFERRED_TYPE(bool)
   unsigned MultiUsers : 1;      ///< Found multiple users.
   const MachineInstr *MI0;      ///< First instruction involved in the LOH.
```

https://github.com/llvm/llvm-project/pull/139825