https://github.com/delcypher commented: Seems reasonable to me other than my coding style nits. I don't own this code though so you should wait for approval from one of the code owners. https://github.com/llvm/llvm-project/pull/139809