[clang] [HLSL] Update Sema Checking Diagnostics for builtins (PR #138429)

[Sarah Spall via cfe-commits]

================
@@ -2507,13 +2441,9 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
     break;
   }
   case Builtin::BI__builtin_hlsl_dot: {
-    if (SemaRef.checkArgCount(TheCall, 2))
----------------
spall wrote:

BuiltinVectorToScalarMath checks that the arg count is 2. I removed checkArgCount checks in places where the next thing checked was something like BuiltinVectorMath, which checks arg count. 

https://github.com/llvm/llvm-project/pull/138429