[clang] [llvm] [HLSL] Add resource constructor with implicit binding for global resources (PR #138976)

Helena Kotas via cfe-commits cfe-commits at lists.llvm.org
Tue May 13 18:28:50 PDT 2025


================
@@ -668,6 +668,26 @@ BuiltinTypeDeclBuilder::addHandleConstructorFromBinding() {
       .finalize();
 }
 
+BuiltinTypeDeclBuilder &
+BuiltinTypeDeclBuilder::addHandleConstructorFromImplicitBinding() {
+  if (Record->isCompleteDefinition())
----------------
hekota wrote:

If I recall correctly, it has something to do with precompiled headers. But now when I tried to remove to see what fails, all of the test pass! So maybe it is not needed anymore?

I would prefer to keep it in for now for consistency with the other constructor and method building functions. I will review all places where this is used and remove them all at once if it is really no longer needed.

https://github.com/llvm/llvm-project/pull/138976


More information about the cfe-commits mailing list