[clang] 9876343 - [clang][bytecode] Optimize enum value range checks (#139672)
via cfe-commits
cfe-commits at lists.llvm.org
Tue May 13 01:55:27 PDT 2025
Author: Timm Baeder
Date: 2025-05-13T10:55:24+02:00
New Revision: 98763433e66dd91bf5f10b1daf03d9373f07912a
URL: https://github.com/llvm/llvm-project/commit/98763433e66dd91bf5f10b1daf03d9373f07912a
DIFF: https://github.com/llvm/llvm-project/commit/98763433e66dd91bf5f10b1daf03d9373f07912a.diff
LOG: [clang][bytecode] Optimize enum value range checks (#139672)
Only do the work if we really have to.
Added:
Modified:
clang/lib/AST/ByteCode/Interp.cpp
clang/lib/AST/ByteCode/Interp.h
Removed:
################################################################################
diff --git a/clang/lib/AST/ByteCode/Interp.cpp b/clang/lib/AST/ByteCode/Interp.cpp
index 43f8d156589b6..91930c016c985 100644
--- a/clang/lib/AST/ByteCode/Interp.cpp
+++ b/clang/lib/AST/ByteCode/Interp.cpp
@@ -1251,12 +1251,11 @@ bool Free(InterpState &S, CodePtr OpPC, bool DeleteIsArrayForm,
void diagnoseEnumValue(InterpState &S, CodePtr OpPC, const EnumDecl *ED,
const APSInt &Value) {
- llvm::APInt Min;
- llvm::APInt Max;
-
if (S.EvaluatingDecl && !S.EvaluatingDecl->isConstexpr())
return;
+ llvm::APInt Min;
+ llvm::APInt Max;
ED->getValueRange(Max, Min);
--Max;
diff --git a/clang/lib/AST/ByteCode/Interp.h b/clang/lib/AST/ByteCode/Interp.h
index a13fd6c1f1daa..35d97167135f7 100644
--- a/clang/lib/AST/ByteCode/Interp.h
+++ b/clang/lib/AST/ByteCode/Interp.h
@@ -3026,10 +3026,11 @@ template <PrimType Name, class T = typename PrimConv<Name>::T>
inline bool CheckEnumValue(InterpState &S, CodePtr OpPC, const EnumDecl *ED) {
assert(ED);
assert(!ED->isFixed());
- const APSInt Val = S.Stk.peek<T>().toAPSInt();
- if (S.inConstantContext())
+ if (S.inConstantContext()) {
+ const APSInt Val = S.Stk.peek<T>().toAPSInt();
diagnoseEnumValue(S, OpPC, ED, Val);
+ }
return true;
}
More information about the cfe-commits
mailing list