[clang] [Serialization] Use StringRef::substr (NFC) (PR #139678)

Kazu Hirata via cfe-commits cfe-commits at lists.llvm.org
Mon May 12 23:54:03 PDT 2025


https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139678

StringRef::substr is shorter here because we can rely on its default
second parameter.


>From 1c1fe61270e62460d09a3d55b7ff23f1d797e72f Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Mon, 12 May 2025 09:26:19 -0700
Subject: [PATCH] [Serialization] Use StringRef::substr (NFC)

StringRef::substr is shorter here because we can rely on its default
second parameter.
---
 clang/lib/Serialization/ASTWriter.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/lib/Serialization/ASTWriter.cpp b/clang/lib/Serialization/ASTWriter.cpp
index c4c0603839c62..7de510c85bfed 100644
--- a/clang/lib/Serialization/ASTWriter.cpp
+++ b/clang/lib/Serialization/ASTWriter.cpp
@@ -1237,7 +1237,7 @@ ASTWriter::createSignature() const {
   Hasher.update(
       AllBytes.slice(UnhashedControlBlockRange.second, ASTBlockRange.first));
   //  3. After the AST block.
-  Hasher.update(AllBytes.slice(ASTBlockRange.second, StringRef::npos));
+  Hasher.update(AllBytes.substr(ASTBlockRange.second));
   ASTFileSignature Signature = ASTFileSignature::create(Hasher.result());
 
   return std::make_pair(ASTBlockHash, Signature);



More information about the cfe-commits mailing list