[clang] [NFC][HLSL][RootSignature] Patch to remove unused variable (PR #139590)

via cfe-commits cfe-commits at lists.llvm.org
Mon May 12 10:26:59 PDT 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-hlsl

Author: Finn Plummer (inbelic)

<details>
<summary>Changes</summary>

- SignatureDecl is currently unused as validation is not yet implemented
- this patch cleans-up the unused variable from when it was used during implementation

---
Full diff: https://github.com/llvm/llvm-project/pull/139590.diff


1 Files Affected:

- (modified) clang/lib/Sema/SemaHLSL.cpp (+1-2) 


``````````diff
diff --git a/clang/lib/Sema/SemaHLSL.cpp b/clang/lib/Sema/SemaHLSL.cpp
index e295114d7617b..744ec439b2393 100644
--- a/clang/lib/Sema/SemaHLSL.cpp
+++ b/clang/lib/Sema/SemaHLSL.cpp
@@ -970,8 +970,7 @@ void SemaHLSL::handleRootSignatureAttr(Decl *D, const ParsedAttr &AL) {
 
   LookupResult R(SemaRef, Ident, SourceLocation(), Sema::LookupOrdinaryName);
   if (SemaRef.LookupQualifiedName(R, D->getDeclContext()))
-    if (auto *SignatureDecl =
-            dyn_cast<HLSLRootSignatureDecl>(R.getFoundDecl())) {
+    if (isa<HLSLRootSignatureDecl>(R.getFoundDecl())) {
       // Perform validation of constructs here
       D->addAttr(::new (getASTContext())
                      RootSignatureAttr(getASTContext(), AL, Ident));

``````````

</details>


https://github.com/llvm/llvm-project/pull/139590


More information about the cfe-commits mailing list