[clang-tools-extra] allow implicit completion inside empty template argument list (PR #138846)

Nathan Ridge via cfe-commits cfe-commits at lists.llvm.org
Sun May 11 20:38:30 PDT 2025


================
@@ -2455,6 +2455,11 @@ bool isIncludeFile(llvm::StringRef Line) {
 }
 
 bool allowImplicitCompletion(llvm::StringRef Content, unsigned Offset) {
+  // Check if we're inside an empty template argument list
----------------
HighCommander4 wrote:

nit: for consistency with the other checks in this function, could you:

 * move this after the "Look at last line before completion only" check; and
 * formulate the check using `ends_with`?

https://github.com/llvm/llvm-project/pull/138846


More information about the cfe-commits mailing list