[clang] [Driver] Use StringRef::consume_back (NFC) (PR #139478)

Kazu Hirata via cfe-commits cfe-commits at lists.llvm.org
Sun May 11 15:51:30 PDT 2025


https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139478

None

>From e74f12c1afc7bd492b9101040d49284200d12638 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Sat, 10 May 2025 23:49:14 -0700
Subject: [PATCH] [Driver] Use StringRef::consume_back (NFC)

---
 clang/lib/Driver/ToolChains/Darwin.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/clang/lib/Driver/ToolChains/Darwin.cpp b/clang/lib/Driver/ToolChains/Darwin.cpp
index fe3952ee76229..26e24ad0ab17c 100644
--- a/clang/lib/Driver/ToolChains/Darwin.cpp
+++ b/clang/lib/Driver/ToolChains/Darwin.cpp
@@ -1411,8 +1411,8 @@ StringRef Darwin::getSDKName(StringRef isysroot) {
   auto EndSDK = llvm::sys::path::rend(isysroot);
   for (auto IT = BeginSDK; IT != EndSDK; ++IT) {
     StringRef SDK = *IT;
-    if (SDK.ends_with(".sdk"))
-        return SDK.slice(0, SDK.size() - 4);
+    if (SDK.consume_back(".sdk"))
+      return SDK;
   }
   return "";
 }



More information about the cfe-commits mailing list