[clang] b194f0e - [Driver] Use StringRef::substr instead of StringRef::slice (NFC) (#139455)
via cfe-commits
cfe-commits at lists.llvm.org
Sun May 11 09:44:57 PDT 2025
Author: Kazu Hirata
Date: 2025-05-11T09:44:54-07:00
New Revision: b194f0e64eee6c1bf1a3ac3899df5e9eb0141604
URL: https://github.com/llvm/llvm-project/commit/b194f0e64eee6c1bf1a3ac3899df5e9eb0141604
DIFF: https://github.com/llvm/llvm-project/commit/b194f0e64eee6c1bf1a3ac3899df5e9eb0141604.diff
LOG: [Driver] Use StringRef::substr instead of StringRef::slice (NFC) (#139455)
StringRef::substr is shorter here because we can rely on its default
second parameter.
Added:
Modified:
clang/lib/Driver/Job.cpp
clang/lib/Driver/ToolChain.cpp
Removed:
################################################################################
diff --git a/clang/lib/Driver/Job.cpp b/clang/lib/Driver/Job.cpp
index f676b12c99a24..880e9e396c41e 100644
--- a/clang/lib/Driver/Job.cpp
+++ b/clang/lib/Driver/Job.cpp
@@ -184,7 +184,7 @@ rewriteIncludes(const llvm::ArrayRef<const char *> &Args, size_t Idx,
StringRef FlagRef(Args[Idx + NumArgs - 1]);
assert((FlagRef.starts_with("-F") || FlagRef.starts_with("-I")) &&
"Expecting -I or -F");
- StringRef Inc = FlagRef.slice(2, StringRef::npos);
+ StringRef Inc = FlagRef.substr(2);
if (getAbsPath(Inc, NewInc)) {
SmallString<128> NewArg(FlagRef.slice(0, 2));
NewArg += NewInc;
diff --git a/clang/lib/Driver/ToolChain.cpp b/clang/lib/Driver/ToolChain.cpp
index 3c52abb0ab78e..664aafad0f680 100644
--- a/clang/lib/Driver/ToolChain.cpp
+++ b/clang/lib/Driver/ToolChain.cpp
@@ -1441,7 +1441,7 @@ std::string ToolChain::detectLibcxxVersion(StringRef IncludePath) const {
StringRef VersionText = llvm::sys::path::filename(LI->path());
int Version;
if (VersionText[0] == 'v' &&
- !VersionText.slice(1, StringRef::npos).getAsInteger(10, Version)) {
+ !VersionText.substr(1).getAsInteger(10, Version)) {
if (Version > MaxVersion) {
MaxVersion = Version;
MaxVersionString = std::string(VersionText);
More information about the cfe-commits
mailing list