[clang] [Driver] Use StringRef::substr instead of StringRef::slice (NFC) (PR #139455)
via cfe-commits
cfe-commits at lists.llvm.org
Sun May 11 09:08:23 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
StringRef::substr is shorter here because we can rely on its default
second parameter.
---
Full diff: https://github.com/llvm/llvm-project/pull/139455.diff
2 Files Affected:
- (modified) clang/lib/Driver/Job.cpp (+1-1)
- (modified) clang/lib/Driver/ToolChain.cpp (+1-1)
``````````diff
diff --git a/clang/lib/Driver/Job.cpp b/clang/lib/Driver/Job.cpp
index f676b12c99a24..880e9e396c41e 100644
--- a/clang/lib/Driver/Job.cpp
+++ b/clang/lib/Driver/Job.cpp
@@ -184,7 +184,7 @@ rewriteIncludes(const llvm::ArrayRef<const char *> &Args, size_t Idx,
StringRef FlagRef(Args[Idx + NumArgs - 1]);
assert((FlagRef.starts_with("-F") || FlagRef.starts_with("-I")) &&
"Expecting -I or -F");
- StringRef Inc = FlagRef.slice(2, StringRef::npos);
+ StringRef Inc = FlagRef.substr(2);
if (getAbsPath(Inc, NewInc)) {
SmallString<128> NewArg(FlagRef.slice(0, 2));
NewArg += NewInc;
diff --git a/clang/lib/Driver/ToolChain.cpp b/clang/lib/Driver/ToolChain.cpp
index 3c52abb0ab78e..664aafad0f680 100644
--- a/clang/lib/Driver/ToolChain.cpp
+++ b/clang/lib/Driver/ToolChain.cpp
@@ -1441,7 +1441,7 @@ std::string ToolChain::detectLibcxxVersion(StringRef IncludePath) const {
StringRef VersionText = llvm::sys::path::filename(LI->path());
int Version;
if (VersionText[0] == 'v' &&
- !VersionText.slice(1, StringRef::npos).getAsInteger(10, Version)) {
+ !VersionText.substr(1).getAsInteger(10, Version)) {
if (Version > MaxVersion) {
MaxVersion = Version;
MaxVersionString = std::string(VersionText);
``````````
</details>
https://github.com/llvm/llvm-project/pull/139455
More information about the cfe-commits
mailing list