[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

Vitaly Buka via cfe-commits cfe-commits at lists.llvm.org
Fri May 9 15:52:43 PDT 2025 

vitalybuka wrote:

```
=================================================================
==3963603==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 576 byte(s) in 1 object(s) allocated from:
    #0 0xb3001e6d179c in operator new(unsigned long) /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/compiler-rt/lib/hwasan/hwasan_new_delete.cpp:64:3
    #1 0xb300271bb420 in make_unique<clang::targets::DarwinAArch64TargetInfo, const llvm::Triple &, const clang::TargetOptions &, 0> /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/libcxx_install_hwasan/include/c++/v1/__memory/unique_ptr.h:759:26
    #2 0xb300271bb420 in clang::targets::AllocateTarget(llvm::Triple const&, clang::TargetOptions const&) /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/lib/Basic/Targets.cpp
    #3 0xb300271cdc84 in clang::TargetInfo::CreateTargetInfo(clang::DiagnosticsEngine&, clang::TargetOptions&) /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/lib/Basic/Targets.cpp:784:40
    #4 0xb300214df800 in makeHeaderSearchFromCC1Args /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/unittests/Frontend/SearchPathTest.cpp:69:9
    #5 0xb300214df800 in clang::(anonymous namespace)::SearchPathTest_SearchPathOrder_Test::TestBody() /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/unittests/Frontend/SearchPathTest.cpp:142:21
    #6 0xb30025b53884 in HandleExceptionsInMethodIfSupported<testing::Test, void> /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc
    #7 0xb30025b53884 in testing::Test::Run() /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc:2687:5
    #8 0xb30025b56bd0 in testing::TestInfo::Run() /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc:2836:11
    #9 0xb30025b589e4 in testing::TestSuite::Run() /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc:3015:30
    #10 0xb30025b7c93c in testing::internal::UnitTestImpl::RunAllTests() /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc:5920:44
    #11 0xb30025b7b310 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc
    #12 0xb30025b7b310 in testing::UnitTest::Run() /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc:5484:10
    #13 0xb30025b2a1e8 in RUN_ALL_TESTS /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:2317:73
    #14 0xb30025b2a1e8 in main /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/UnitTestMain/TestMain.cpp:55:10
    #15 0xe02b3b1884c0  (/lib/aarch64-linux-gnu/libc.so.6+0x284c0) (BuildId: 1d7249a4f207d07166ff4be43acdc68a01faaa04)
    #16 0xe02b3b188594 in __libc_start_main (/lib/aarch64-linux-gnu/libc.so.6+0x28594) (BuildId: 1d7249a4f207d07166ff4be43acdc68a01faaa04)
    #17 0xb3001e6962ec in _start (/home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/clang/unittests/AllClangUnitTests+0x67d62ec)

Indirect leak of 72 byte(s) in 1 object(s) allocated from:
    #0 0xb3001e6d179c in operator new(unsigned long) /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/compiler-rt/lib/hwasan/hwasan_new_delete.cpp:64:3
    #1 0xb300271b00e8 in __libcpp_operator_new<unsigned long> /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/libcxx_install_hwasan/include/c++/v1/__new/allocate.h:37:10
    #2 0xb300271b00e8 in __libcpp_allocate<char> /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/libcxx_install_hwasan/include/c++/v1/__new/allocate.h:64:28
    #3 0xb300271b00e8 in allocate /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/libcxx_install_hwasan/include/c++/v1/__memory/allocator.h:105:14
    #4 0xb300271b00e8 in __allocate_at_least<std::__1::allocator<char> > /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/libcxx_install_hwasan/include/c++/v1/__memory/allocate_at_least.h:41:19
    #5 0xb300271b00e8 in __init /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/libcxx_install_hwasan/include/c++/v1/string:2545:25
    #6 0xb300271b00e8 in basic_string /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/libcxx_install_hwasan/include/c++/v1/string:1070:5
    #7 0xb300271b00e8 in str /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/include/llvm/ADT/StringRef.h:232:14
    #8 0xb300271b00e8 in clang::TargetInfo::resetDataLayout(llvm::StringRef, char const*) /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/lib/Basic/TargetInfo.cpp:194:25
    #9 0xb30027235e7c in clang::targets::AArch64TargetInfo::handleTargetFeatures(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>>&, clang::DiagnosticsEngine&) /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/lib/Basic/Targets/AArch64.cpp:1203:3
    #10 0xb300271cf63c in clang::TargetInfo::CreateTargetInfo(clang::DiagnosticsEngine&, clang::TargetOptions&) /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/lib/Basic/Targets.cpp:845:16
    #11 0xb300214df800 in makeHeaderSearchFromCC1Args /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/unittests/Frontend/SearchPathTest.cpp:69:9
    #12 0xb300214df800 in clang::(anonymous namespace)::SearchPathTest_SearchPathOrder_Test::TestBody() /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/unittests/Frontend/SearchPathTest.cpp:142:21
    #13 0xb30025b53884 in HandleExceptionsInMethodIfSupported<testing::Test, void> /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc
    #14 0xb30025b53884 in testing::Test::Run() /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc:2687:5
    #15 0xb30025b56bd0 in testing::TestInfo::Run() /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc:2836:11
    #16 0xb30025b589e4 in testing::TestSuite::Run() /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc:3015:30
    #17 0xb30025b7c93c in testing::internal::UnitTestImpl::RunAllTests() /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc:5920:44
    #18 0xb30025b7b310 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc
    #19 0xb30025b7b310 in testing::UnitTest::Run() /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc:5484:10
    #20 0xb30025b2a1e8 in RUN_ALL_TESTS /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:2317:73
    #21 0xb30025b2a1e8 in main /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/UnitTestMain/TestMain.cpp:55:10
    #22 0xe02b3b1884c0  (/lib/aarch64-linux-gnu/libc.so.6+0x284c0) (BuildId: 1d7249a4f207d07166ff4be43acdc68a01faaa04)
    #23 0xe02b3b188594 in __libc_start_main (/lib/aarch64-linux-gnu/libc.so.6+0x28594) (BuildId: 1d7249a4f207d07166ff4be43acdc68a01faaa04)
    #24 0xb3001e6962ec in _start (/home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/clang/unittests/AllClangUnitTests+0x67d62ec)

Indirect leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0xb3001e6d179c in operator new(unsigned long) /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/compiler-rt/lib/hwasan/hwasan_new_delete.cpp:64:3
    #1 0xb3001e6d2768 in __libcpp_operator_new<unsigned long> /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/libcxx_install_hwasan/include/c++/v1/__new/allocate.h:37:10
    #2 0xb3001e6d2768 in __libcpp_allocate<char> /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/libcxx_install_hwasan/include/c++/v1/__new/allocate.h:64:28
    #3 0xb3001e6d2768 in allocate /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/libcxx_install_hwasan/include/c++/v1/__memory/allocator.h:105:14
    #4 0xb3001e6d2768 in __allocate_at_least<std::__1::allocator<char> > /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/libcxx_install_hwasan/include/c++/v1/__memory/allocate_at_least.h:41:19
    #5 0xb3001e6d2768 in std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>::__init_copy_ctor_external(char const*, unsigned long) /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/libcxx_install_hwasan/include/c++/v1/string:2570:25
    #6 0xb300271af148 in basic_string /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/libcxx_install_hwasan/include/c++/v1/string:997:7
    #7 0xb300271af148 in Triple /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/include/llvm/TargetParser/Triple.h:44:7
    #8 0xb300271af148 in clang::TargetInfo::TargetInfo(llvm::Triple const&) /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/lib/Basic/TargetInfo.cpp:56:49
    #9 0xb300272222f8 in clang::targets::AArch64TargetInfo::AArch64TargetInfo(llvm::Triple const&, clang::TargetOptions const&) /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/lib/Basic/Targets/AArch64.cpp:204:7
    #10 0xb3002723a27c in AArch64leTargetInfo /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/lib/Basic/Targets/AArch64.cpp:1617:7
    #11 0xb3002723a27c in OSTargetInfo /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/lib/Basic/Targets/OSTargets.h:28:9
    #12 0xb3002723a27c in AppleMachOTargetInfo /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/lib/Basic/Targets/OSTargets.h:55:9
    #13 0xb3002723a27c in clang::targets::DarwinTargetInfo<clang::targets::AArch64leTargetInfo>::DarwinTargetInfo(llvm::Triple const&, clang::TargetOptions const&) /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/lib/Basic/Targets/OSTargets.h:79:9
    #14 0xb30027239fa0 in clang::targets::DarwinAArch64TargetInfo::DarwinAArch64TargetInfo(llvm::Triple const&, clang::TargetOptions const&) /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/lib/Basic/Targets/AArch64.cpp:1769:7
    #15 0xb300271bb430 in make_unique<clang::targets::DarwinAArch64TargetInfo, const llvm::Triple &, const clang::TargetOptions &, 0> /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/libcxx_install_hwasan/include/c++/v1/__memory/unique_ptr.h:759:30
    #16 0xb300271bb430 in clang::targets::AllocateTarget(llvm::Triple const&, clang::TargetOptions const&) /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/lib/Basic/Targets.cpp
    #17 0xb300271cdc84 in clang::TargetInfo::CreateTargetInfo(clang::DiagnosticsEngine&, clang::TargetOptions&) /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/lib/Basic/Targets.cpp:784:40
    #18 0xb300214df800 in makeHeaderSearchFromCC1Args /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/unittests/Frontend/SearchPathTest.cpp:69:9
    #19 0xb300214df800 in clang::(anonymous namespace)::SearchPathTest_SearchPathOrder_Test::TestBody() /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/clang/unittests/Frontend/SearchPathTest.cpp:142:21
    #20 0xb30025b53884 in HandleExceptionsInMethodIfSupported<testing::Test, void> /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc
    #21 0xb30025b53884 in testing::Test::Run() /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc:2687:5
    #22 0xb30025b56bd0 in testing::TestInfo::Run() /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc:2836:11
    #23 0xb30025b589e4 in testing::TestSuite::Run() /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc:3015:30
    #24 0xb30025b7c93c in testing::internal::UnitTestImpl::RunAllTests() /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc:5920:44
    #25 0xb30025b7b310 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc
    #26 0xb30025b7b310 in testing::UnitTest::Run() /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/src/gtest.cc:5484:10
    #27 0xb30025b2a1e8 in RUN_ALL_TESTS /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:2317:73
    #28 0xb30025b2a1e8 in main /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/third-party/unittest/UnitTestMain/TestMain.cpp:55:10
    #29 0xe02b3b1884c0  (/lib/aarch64-linux-gnu/libc.so.6+0x284c0) (BuildId: 1d7249a4f207d07166ff4be43acdc68a01faaa04)
    #30 0xe02b3b188594 in __libc_start_main (/lib/aarch64-linux-gnu/libc.so.6+0x28594) (BuildId: 1d7249a4f207d07166ff4be43acdc68a01faaa04)
    #31 0xb3001e6962ec in _start (/home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/clang/unittests/AllClangUnitTests+0x67d62ec)

SUMMARY: HWAddressSanitizer: 680 byte(s) leaked in 3 allocation(s).

```

https://github.com/llvm/llvm-project/pull/138234

More information about the cfe-commits mailing list