[clang] Reland "Reland [Modules] Remove unnecessary check when generating name lookup table in ASTWriter" (PR #139253)

via cfe-commits cfe-commits at lists.llvm.org
Fri May 9 05:30:22 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cppm,cpp,h -- clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/pr61065.cppm
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Serialization/ASTWriter.cpp b/clang/lib/Serialization/ASTWriter.cpp
index 10e82fb5b..63dcf6687 100644
--- a/clang/lib/Serialization/ASTWriter.cpp
+++ b/clang/lib/Serialization/ASTWriter.cpp
@@ -4555,7 +4555,7 @@ void ASTWriter::GenerateNameLookupTable(
   // order.
   SmallVector<DeclarationName, 16> Names;
 
-   // We also track whether we're writing out the DeclarationNameKey for
+  // We also track whether we're writing out the DeclarationNameKey for
   // constructors or conversion functions.
   bool IncludeConstructorNames = false;
   bool IncludeConversionNames = false;
@@ -4569,7 +4569,7 @@ void ASTWriter::GenerateNameLookupTable(
     // Also in reduced BMI, we'd like to avoid writing unreachable
     // declarations in GMF, so we need to avoid writing declarations
     // that entirely external or unreachable.
-     if (GeneratingReducedBMI && isLookupResultNotInteresting(*this, Result))
+    if (GeneratingReducedBMI && isLookupResultNotInteresting(*this, Result))
       continue;
     // We also skip empty results. If any of the results could be external and
     // the currently available results are empty, then all of the results are

``````````

</details>


https://github.com/llvm/llvm-project/pull/139253


More information about the cfe-commits mailing list