[clang] [clang] Constant-evaluate format strings as last resort (PR #135864)

[via cfe-commits]

=?utf-8?q?Félix?= Cloutier <fcloutier at apple.com>,
=?utf-8?q?Félix?= Cloutier <fcloutier at apple.com>,
=?utf-8?q?Félix?= Cloutier <fcloutier at apple.com>,
=?utf-8?q?Félix?= Cloutier <fcloutier at apple.com>,
=?utf-8?q?Félix?= Cloutier <fcloutier at apple.com>,
=?utf-8?q?Félix?= Cloutier <fcloutier at apple.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/135864 at github.com>


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions h,c,cpp -- clang/include/clang/AST/Expr.h clang/lib/AST/ExprConstant.cpp clang/lib/Analysis/UnsafeBufferUsage.cpp clang/lib/CodeGen/CGBuiltin.cpp clang/lib/Sema/SemaChecking.cpp clang/test/Sema/format-strings.c clang/test/SemaCXX/format-strings.cpp clang/test/SemaCXX/verbose-trap.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp
index 575ba8b58..966bf0504 100644
--- a/clang/lib/Sema/SemaChecking.cpp
+++ b/clang/lib/Sema/SemaChecking.cpp
@@ -6074,8 +6074,7 @@ class FormatStringFinder {
                      ArrayRef<const Expr *> Args,
                      llvm::SmallBitVector &CheckedVarArgs,
                      UncoveredArgHandler &UncoveredArg,
-                     Sema::FormatArgumentPassingKind APK,
-                     FormatStringType Type,
+                     Sema::FormatArgumentPassingKind APK, FormatStringType Type,
                      VariadicCallType CallType, unsigned format_idx,
                      unsigned firstDataArg, bool InFunctionCall)
       : S(S), ReferenceFormatString(ReferenceFormatString), Args(Args),

``````````

</details>


https://github.com/llvm/llvm-project/pull/135864