[clang-tools-extra] [clang-doc][NFC] Fix missing documentation for EndLineNumber (PR #138051)

Daniel Thornburgh via cfe-commits cfe-commits at lists.llvm.org
Wed May 7 11:12:01 PDT 2025


================
@@ -262,8 +262,8 @@ struct Location {
            std::tie(Other.StartLineNumber, Other.EndLineNumber, Other.Filename);
   }
 
-  int StartLineNumber = 0; // Line number of this Location.
-  int EndLineNumber = 0;
+  int StartLineNumber = 0;      // Line number of this Location.
----------------
mysterymath wrote:

Honestly comments like this are a bit of a pet peeve. None of these have any information that isn't already in the symbol name. I'd say that these comments should either provide some contextual hints about why this information is necessary, a more detailed description of their semantics, etc., or otherwise, should be removed.

https://github.com/llvm/llvm-project/pull/138051


More information about the cfe-commits mailing list