[clang] [Clang][Cygwin] attempt to fix building shared libclang. (PR #138351)

via cfe-commits cfe-commits at lists.llvm.org
Fri May 2 14:57:42 PDT 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: None (jeremyd2019)

<details>
<summary>Changes</summary>

@<!-- -->mstorsjo I don't understand why this isn't working.  We know it works for MinGW right?

---
Full diff: https://github.com/llvm/llvm-project/pull/138351.diff


2 Files Affected:

- (modified) clang/include/clang-c/Platform.h (+1-1) 
- (modified) clang/tools/libclang/CMakeLists.txt (+1-1) 


``````````diff
diff --git a/clang/include/clang-c/Platform.h b/clang/include/clang-c/Platform.h
index 67c1fff8ff783..8d341ddd6f8eb 100644
--- a/clang/include/clang-c/Platform.h
+++ b/clang/include/clang-c/Platform.h
@@ -22,7 +22,7 @@ LLVM_CLANG_C_EXTERN_C_BEGIN
 #ifndef CINDEX_NO_EXPORTS
   #define CINDEX_EXPORTS
 #endif
-#ifdef _WIN32
+#if defined(_WIN32) || defined(__CYGWIN__)
   #ifdef CINDEX_EXPORTS
     #ifdef _CINDEX_LIB_
       #define CINDEX_LINKAGE __declspec(dllexport)
diff --git a/clang/tools/libclang/CMakeLists.txt b/clang/tools/libclang/CMakeLists.txt
index 37a939ffcada7..454dfead0bcf5 100644
--- a/clang/tools/libclang/CMakeLists.txt
+++ b/clang/tools/libclang/CMakeLists.txt
@@ -158,7 +158,7 @@ if(ENABLE_STATIC)
 endif()
 
 if(ENABLE_SHARED)
-  if(WIN32)
+  if(WIN32 OR CYGWIN)
     set_target_properties(libclang
       PROPERTIES
       VERSION ${LIBCLANG_LIBRARY_VERSION}

``````````

</details>


https://github.com/llvm/llvm-project/pull/138351


More information about the cfe-commits mailing list