[clang-tools-extra] [NFC] Fix potential nullptr dereference. (PR #138283)

Nicolas van Kempen via cfe-commits cfe-commits at lists.llvm.org
Fri May 2 09:44:27 PDT 2025


https://github.com/nicovank requested changes to this pull request.

This is not needed IMO. This is a simple matcher, `op` is expected to always be bound.

One might say that it can't hurt to add extra checks, but I don't think that's good justification for adding more code / bloat, even if in this case it's a single line. Still, 5% more code for this check counting non-empty non-comment lines!

Happy to disagree if any of the maintainers think otherwise.

https://github.com/llvm/llvm-project/pull/138283


More information about the cfe-commits mailing list