[clang] [clang-format] RemoveParentheses shouldn't remove empty parentheses (PR #138229)
via cfe-commits
cfe-commits at lists.llvm.org
Thu May 1 21:11:42 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
<details>
<summary>Changes</summary>
Fix #<!-- -->138124
---
Full diff: https://github.com/llvm/llvm-project/pull/138229.diff
2 Files Affected:
- (modified) clang/lib/Format/UnwrappedLineParser.cpp (+2-1)
- (modified) clang/unittests/Format/FormatTest.cpp (+2)
``````````diff
diff --git a/clang/lib/Format/UnwrappedLineParser.cpp b/clang/lib/Format/UnwrappedLineParser.cpp
index 837146f0c6483..b67634c7f8ee0 100644
--- a/clang/lib/Format/UnwrappedLineParser.cpp
+++ b/clang/lib/Format/UnwrappedLineParser.cpp
@@ -2599,7 +2599,8 @@ bool UnwrappedLineParser::parseParens(TokenType AmpAmpTokenType) {
if (Prev) {
auto OptionalParens = [&] {
if (MightBeStmtExpr || MightBeFoldExpr || Line->InMacroBody ||
- SeenComma || Style.RemoveParentheses == FormatStyle::RPS_Leave) {
+ SeenComma || Style.RemoveParentheses == FormatStyle::RPS_Leave ||
+ RParen->getPreviousNonComment() == LParen) {
return false;
}
const bool DoubleParens =
diff --git a/clang/unittests/Format/FormatTest.cpp b/clang/unittests/Format/FormatTest.cpp
index c4fcc5506d152..049df57ab5725 100644
--- a/clang/unittests/Format/FormatTest.cpp
+++ b/clang/unittests/Format/FormatTest.cpp
@@ -28453,6 +28453,8 @@ TEST_F(FormatTest, RemoveParentheses) {
verifyFormat("return ((... && std::is_convertible_v<TArgsLocal, TArgs>));",
"return (((... && std::is_convertible_v<TArgsLocal, TArgs>)));",
Style);
+ verifyFormat("MOCK_METHOD(void, Function, (), override);",
+ "MOCK_METHOD(void, Function, (), (override));", Style);
Style.RemoveParentheses = FormatStyle::RPS_ReturnStatement;
verifyFormat("#define Return0 return (0);", Style);
``````````
</details>
https://github.com/llvm/llvm-project/pull/138229
More information about the cfe-commits
mailing list