[clang] [llvm] [mlir] [Sema] Fix bug in builtin AS override (PR #138141)
Joe Nash via cfe-commits
cfe-commits at lists.llvm.org
Thu May 1 08:46:37 PDT 2025
Sisyph wrote:
> The patch to SemaExpr looks reasonable to me. I'd suggest that goes in separate from the amdgpu intrinsic stuff.
>
> I'd test this by tweaking the code to do the current lowering _and_ the proposed and check that they do exactly the same thing on all the existing builtins, then drop the current code path, but ymmv in terms of how that strategy interacts with our code review system.
Thanks. I will wait for https://github.com/llvm/llvm-project/pull/137425 to be resolved, then rebase or convert this PR as needed.
https://github.com/llvm/llvm-project/pull/138141
More information about the cfe-commits
mailing list