[clang-tools-extra] [clang-tidy] do not diagnose array types within implicit instantiations of a template (PR #132924)

[St. Muench via cfe-commits]

================
@@ -39,6 +39,30 @@ AST_MATCHER(clang::ParmVarDecl, isArgvOfMain) {
   return FD ? FD->isMain() : false;
 }
 
+bool isWithinImplicitTemplateInstantiation(const TypeLoc *MatchedTypeLoc,
----------------
stmuench wrote:

> Could you please elaborate what is this function for? I deleted its call in `not(isWithinImplicitTemplateInstantiation(...))` and all tests passed. I suggest we can delete this function or add tests cases to cover added behavior.

If I remove this function on my side, the unit tests start to fail since diagnostics get emitted then for implicit template instantiations.

https://github.com/llvm/llvm-project/pull/132924