[clang-tools-extra] [clang-tidy] Return error code on config parse error (PR #136167)

[Carlos Galvez via cfe-commits]

================
@@ -266,7 +266,7 @@ ClangTidyOptions ClangTidyContext::getOptionsForFile(StringRef File) const {
   // Merge options on top of getDefaults() as a safeguard against options with
   // unset values.
   return ClangTidyOptions::getDefaults().merge(
-      OptionsProvider->getOptions(File), 0);
+      *OptionsProvider->getOptions(File), 0);
----------------
carlosgalvezp wrote:

How do we know if we can safely dereference without checking if we have an error?

https://github.com/llvm/llvm-project/pull/136167