[clang] [llvm] [HLSL][DXIL] Implement `refract` intrinsic (PR #136026)

Kaitlin Peng via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 29 12:11:29 PDT 2025


================
@@ -71,6 +71,27 @@ constexpr vector<T, L> reflect_vec_impl(vector<T, L> I, vector<T, L> N) {
 #endif
 }
 
+template <typename T> constexpr T refract_impl(T I, T N, T eta) {
+  T k = 1 - eta * eta * (1 - (N * I * N *I));
----------------
kmpeng wrote:

Variables should [start with an upper-case letter](https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly) (i.e. K, Eta). Should be upper-case in the other files too.

https://github.com/llvm/llvm-project/pull/136026


More information about the cfe-commits mailing list